"TODO: Make this work"

[Zachary-Kramer]

I was modifying the output for CO2 and came across the following comment on line 773 of SW_Output.c. Does any one know what needed to be done here?

PROTECT(sep = GET_SLOT(OUT, install("outputSeparator")));
_Sep = '\t';/*TODO Make this work.*/
PROTECT(useTimeStep = GET_SLOT(OUT, install("useTimeStep")));```

[dschlaep]

Based on blame, this comment was added with commit 477acff by Ryan.

I guess this comment was meant to suggest that the code should be improved so that it allows _Sep take the value of the input sep instead of it being fixed at \t?

[Zachary-Kramer]

Thanks. It seems that _Sep is defaulted at \t but can be changed to a space or sumtype based on OUTSEP:

if (Str_CompareI(keyname, "OUTSEP") == 0)
				{
					switch ((int) *sumtype)
					{
					case 't':
						_Sep = '\t';
						break;
					case 's':
						_Sep = ' ';
						break;
					default:
						_Sep = *sumtype;
					}
					continue;
				}

It seems that one just can't set it through rSOILWAT2's onSet_SW_OUT (maybe even calling onSet overwrites the file value above?).

Should a low priority issue be created?

[dschlaep]

`SOILWAT2` is capable to work with different separators. `rSOILWAT2` is currently not capable to do that. I don't see an urgent need. A low priority issue sounds good. Thanks.

…

On Oct 6, 2017, at 13:30, Zachary Kramer ***@***.***> wrote: Thanks. It seems that _Sep is defaulted at \t but can be changed to a space or sumtype based on OUTSEP: if (Str_CompareI(keyname, "OUTSEP") == 0) { switch ((int) *sumtype) { case 't': _Sep = '\t'; break; case 's': _Sep = ' '; break; default: _Sep = *sumtype; } continue; } It seems that one just can't set it through rSOILWAT2's onSet_SW_OUT (maybe even calling onSet overwrites the file value above?). Should a low priority issue be created? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#77 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEAp25Nvj6ZM-BR96FZeABNfXGWWZ-1Iks5spmOZgaJpZM4PvVTB>.