-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create aggregrated antecedent weather available for use in wildfire-feedback cheatgrass loop #412
Comments
I've been thinking though this issue and I believe the cleanest solution would be to create a new struct for the cheatgrass information:
That way all of the information is together. While we are at it, I think it would also be a good idea to create a header file for Mortality called @kpalmqui how does that sound? |
@chaukap I think making a new struct for cheatgrass makes sense. However, while the header file for Mortality seems like a good idea, shouldn't this be implemented in a different milestone/development branch? |
@kpalmqui It would be a little messy to create the header file so I agree. I'll get to work on this issue right away. |
@kpalmqui When you say "last winter" do you mean the previous year's October-December precipitation plus the current year's January-March precipitation, or do you mean the October-December precipitation from 2 years ago and the January-March precipitation from 1 year ago? I'm assuming the first but I want to be sure. |
@chaukap thanks for following up about this. The Pilliod et al. 2017 study characterized a year as: October-September (see attached Figure). Thus, with regard to your question it is actually the second: October-December precipitation from 2 years ago and the January-March precipitation from 1 year ago |
(issue #412) The new struct CheatgrassPrecip stores all of the information needed to determine cheatgrass-driven wildfire occurances. The function _updateCheatgrassPrecip should be called once a year to update the fields in the struct, and memory allocation is handled with initCheatgrassPrecip and freeMortalityMemory. I still need to incoprorate the new struct into gridded mode, but non-gridded mode is ready to utilize the variables.
(issue #412) The cheatgrass precipitation information is now cell-specific and loads into the mortality module when load_cell is called.
I added the parameter "year" to the function documentation of _updateCheatgrassPrecip and consolidated a few long winded comments.
@kpalmqui Following commit 4f1a375 I believe all of the information you requested is available. Here's a summary of what I've done:
To access the information:
TestingYou can test my implementation using the print statement I left below the call to If there's anything else you need let me know! |
I felt like the documentation needed a few more things to feel complete. (issue #412)
The antecedent weather is available to the wildfire code and therefore this issue is complete. If any modifications to the weather data need to be made I will open a new branch. |
In addition to fire probability based on cheatgrass biomass (see #324), we would like antecedent weather in the previous three years to be utilized for additional adjustment of the fire probability that is calculated based on cheatgrass biomass.
@menglandjohns and I are still working on the logic and code implementation for this (more details to follow), but we would like @chaukap to begin working on the code that creates the aggregated antecedent weather variables of interest. These variables were identified in Pilliod et al. 2017:
Pilliod et al. 2017.pdf
For each year, we want:
Using these variables, we will need to essentially check to see if the following are true:
Because of these comparison to "average" conditions, we will also need running means for the above variables.
For year 1, we have no previous weather data to go on, so this implementation should be skipped. For years 2-3, I suggest we utilize the spring precipitation in the previous year and mean spring precipitation in the previous two years, respectively.
Much more detail to come here as we finalize:
@chaukap let me know if you have initial questions and feel free to break this down into smaller issues if you would like.
The text was updated successfully, but these errors were encountered: