Feature soilwat2 with co2 #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- SOILWAT2 commit DrylandEcology/SOILWAT2@2063e38643b7ad49c e0eade239e8093886c7c123 cleaned up struct 'SW_VEGPROD': * defined struct 'VegTypeOut' and 'CoverType'
- update makefile
- close DrylandEcology/SOILWAT2#99 - CO2 flags are turned off - this commit compiles and executes the testing example
kpalmqui
approved these changes
Dec 7, 2017
There was a problem hiding this comment.
The PR compiles properly. I tested with CO2 off and found no difference in the output (bmassavg.csv) or debugging output files between this PR and the master branch. Turning off the CO2 features within STEPWAT2 is fine for now. I will add an issue to STEPWAT2 to incorporate additional changes to make the CO2 code functional with STEPWAT2. For instance, we will need to add the carbon.in file to /Stepwat_Inputs/Input/sxw/Input.
|
Let's wait with merging the pull request into master until the corresponding soilwat_co2_effects branch of SOIILWAT2 is merged into master. |
- added input for runon fraction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust code so that the CO2-enabled version of SOILWAT2 can be used as submodule (currently tracking the soilwat_co2_effects branch of SOILWAT2).
This PR compiles and the testing example runs well and produces output similar to the output generated by #50