Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare STEPWAT2 to handle SOILWAT2's additional daily inputs #539

Merged
merged 7 commits into from
Jun 5, 2023

Conversation

dschlaep
Copy link
Member

@dschlaep dschlaep commented Feb 6, 2023

See SOILWAT2's PR DrylandEcology/SOILWAT2#338 and issue DrylandEcology/SOILWAT2#341

SOILWAT2 is gaining the ability to handle additional daily inputs (for atmospheric demand) while being fully backwards compatible. However, the weather generator is currently not updated to handle additional daily variables (DrylandEcology/SOILWAT2#343). This PR sets STEPWAT2 up to interact with SOILWAT2 as before, i.e., without utilizing the new daily variables.

Nicholas Persley added 4 commits January 29, 2023 13:18
- The updated submodule (SOILWAT2) has the ability to read new daily weather variables in weath.YYYY. The new variables are:
	* Cloud cover, (maximum/minimum) relative humidity, (east/north components of) wind speed, shortwave radiation, actual vapor pressure, specific humidity, and dewpoint temperature
- "sxw_soilwat.c" gains the include of "SW_Sky.h" to extern the variable, "SW_Sky"
- `_sxw_generate_weather()` makes sure monthly input flags are set, so when the weather generator runs, cloud cover, humidity, and wind speed are filled with daily interpolated values from monthly input
@dschlaep dschlaep marked this pull request as draft February 6, 2023 15:43
- for details, see DrylandEcology/SOILWAT2#345
-> "weathsetup.in" gained a new input "description of downward surface shortwave radiation"

-> none of that is currently relevant or active for STEPWAT2

- this commit produces identical output to commit c974dc6 on branch feature_SOILWAT2_v700_devel
@dschlaep dschlaep marked this pull request as ready for review June 5, 2023 13:22
@dschlaep dschlaep merged commit 1e97e9e into feature_SOILWAT2_v700_devel Jun 5, 2023
1 of 2 checks passed
@dschlaep dschlaep deleted the read_more_daily_input branch June 5, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants