Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a way to disable the "make_dbOutput" function? #371

Open
CaitlinA opened this issue Nov 5, 2019 · 2 comments
Open

Is there a way to disable the "make_dbOutput" function? #371

CaitlinA opened this issue Nov 5, 2019 · 2 comments
Assignees

Comments

@CaitlinA
Copy link
Member

CaitlinA commented Nov 5, 2019

@dschlaep

I am interested in disabling the make_dbOutput function when sim_aggregate is FALSE

If I am understanding sim_aggregate correctly, then when sim_aggregate (as well as concat_dbOut) is set to FALSE in the SFSW2_project_code.R there is no reason to make an output DB. This could be a huge time saver.

What do you think?

@dschlaep
Copy link
Member

dschlaep commented Nov 5, 2019

I agree that this would be a good enhancement. However, the existing code was built around the assumption that dbOutput was always requested.

There are several crucial parts of the wrapper that rely on dbOutput. For instance,

  • making sure that dbWork is up-to-date calls recreate_dbWork which uses dbOutput
  • the main simulation function do_OneSite uses information from dbOutput in several cases, e.g., to locate weather data

As a work-around until someone implements this enhancement: use quickprepare_dbOutput_dbWork to locally create dbOutput once, and then copy it in the correct/expected places so that each call to the wrapper (e.g., on an expensive machine) does not need to create it's own copy.

@CaitlinA
Copy link
Member Author

CaitlinA commented Nov 5, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants