Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

40 compiler warnings from SW_Output.c #117

Closed
dschlaep opened this issue Apr 2, 2018 · 2 comments
Closed

40 compiler warnings from SW_Output.c #117

dschlaep opened this issue Apr 2, 2018 · 2 comments
Assignees
@BrendenBe1
Milestone
Incorporate SOILW...

Comments

@dschlaep
Copy link
Member

dschlaep commented Apr 2, 2018

40 compiler warnings from SW_Output.c

SW_Output.c:1336:8: warning: unused variable 'soil_file_vals_day' [-Wunused-variable]
        char *soil_file_vals_day[500]; // store
              ^
SW_Output.c:1339:8: warning: unused variable 'soil_file_vals_week' [-Wunused-variable]
        char *soil_file_vals_week[500]; // store
              ^
SW_Output.c:1343:8: warning: unused variable 'reg_file_vals_month' [-Wunused-variable]
        char *reg_file_vals_month[500]; // store
              ^
SW_Output.c:1346:8: warning: unused variable 'reg_file_vals_year' [-Wunused-variable]
        char *reg_file_vals_year[500]; // store
              ^
SW_Output.c:1337:8: warning: unused variable 'reg_file_vals_day' [-Wunused-variable]
        char *reg_file_vals_day[500]; // store
              ^
SW_Output.c:1342:8: warning: unused variable 'soil_file_vals_month' [-Wunused-variable]
        char *soil_file_vals_month[500]; // store
              ^
SW_Output.c:1345:8: warning: unused variable 'soil_file_vals_year' [-Wunused-variable]
        char *soil_file_vals_year[500]; // store
              ^
SW_Output.c:1340:8: warning: unused variable 'reg_file_vals_week' [-Wunused-variable]
        char *reg_file_vals_week[500]; // store
              ^
SW_Output.c:2228:7: warning: unused variable 'str' [-Wunused-variable]
        char str[OUTSTRLEN];
             ^
SW_Output.c:3020:8: warning: unused variable 'val' [-Wunused-variable]
        RealF val[NVEGTYPES][MAX_LAYERS]; // need 2D array for values
              ^
SW_Output.c:3016:7: warning: unused variable 'str' [-Wunused-variable]
        char str[OUTSTRLEN];
             ^
SW_Output.c:3184:8: warning: unused variable 'val' [-Wunused-variable]
        RealD val = SW_MISSING;
              ^
SW_Output.c:3318:8: warning: unused variable 'val' [-Wunused-variable]
        RealD val = SW_MISSING;
              ^
SW_Output.c:3460:8: warning: unused variable 'val' [-Wunused-variable]
        RealD val = SW_MISSING;
              ^
SW_Output.c:3591:8: warning: unused variable 'val' [-Wunused-variable]
        RealD val = SW_MISSING, convert;
              ^
SW_Output.c:3733:8: warning: unused variable 'val_surfacewater' [-Wunused-variable]
        RealD val_surfacewater = SW_MISSING;
              ^
SW_Output.c:4440:8: warning: unused variable 'val' [-Wunused-variable]
        RealD val = SW_MISSING;
              ^
SW_Output.c:4560:28: warning: unused variable 'val_grass' [-Wunused-variable]
                        val_shrub = SW_MISSING, val_grass = SW_MISSING, val_litter =
                                                ^
SW_Output.c:4560:4: warning: unused variable 'val_shrub' [-Wunused-variable]
                        val_shrub = SW_MISSING, val_grass = SW_MISSING, val_litter =
                        ^
SW_Output.c:4559:8: warning: unused variable 'val_tot' [-Wunused-variable]
        RealD val_tot = SW_MISSING, val_tree = SW_MISSING, val_forb = SW_MISSING,
              ^
SW_Output.c:4559:53: warning: unused variable 'val_forb' [-Wunused-variable]
        RealD val_tot = SW_MISSING, val_tree = SW_MISSING, val_forb = SW_MISSING,
                                                           ^
SW_Output.c:4561:18: warning: unused variable 'val_water' [-Wunused-variable]
                                        SW_MISSING, val_water = SW_MISSING;
                                                    ^
SW_Output.c:4559:30: warning: unused variable 'val_tree' [-Wunused-variable]
        RealD val_tot = SW_MISSING, val_tree = SW_MISSING, val_forb = SW_MISSING,
                                    ^
SW_Output.c:4560:52: warning: unused variable 'val_litter' [-Wunused-variable]
                        val_shrub = SW_MISSING, val_grass = SW_MISSING, val_litter =
                                                                        ^
SW_Output.c:4795:4: warning: unused variable 'val_shrub' [-Wunused-variable]
                        val_shrub = SW_MISSING, val_grass = SW_MISSING, val_litter =
                        ^
SW_Output.c:4794:53: warning: unused variable 'val_forb' [-Wunused-variable]
        RealD val_tot = SW_MISSING, val_tree = SW_MISSING, val_forb = SW_MISSING,
                                                           ^
SW_Output.c:4794:30: warning: unused variable 'val_tree' [-Wunused-variable]
        RealD val_tot = SW_MISSING, val_tree = SW_MISSING, val_forb = SW_MISSING,
                                    ^
SW_Output.c:4795:52: warning: unused variable 'val_litter' [-Wunused-variable]
                        val_shrub = SW_MISSING, val_grass = SW_MISSING, val_litter =
                                                                        ^
SW_Output.c:4794:8: warning: unused variable 'val_tot' [-Wunused-variable]
        RealD val_tot = SW_MISSING, val_tree = SW_MISSING, val_forb = SW_MISSING,
              ^
SW_Output.c:4795:28: warning: unused variable 'val_grass' [-Wunused-variable]
                        val_shrub = SW_MISSING, val_grass = SW_MISSING, val_litter =
                                                ^
SW_Output.c:5014:8: warning: unused variable 'val_inf' [-Wunused-variable]
        RealD val_inf = SW_MISSING;
              ^
SW_Output.c:5137:8: warning: unused variable 'val' [-Wunused-variable]
        RealD val = SW_MISSING;
              ^
SW_Output.c:5277:8: warning: unused variable 'val_total' [-Wunused-variable]
        RealD val_total = SW_MISSING;
              ^
SW_Output.c:5280:8: warning: unused variable 'val_forb' [-Wunused-variable]
        RealD val_forb = SW_MISSING;
              ^
SW_Output.c:5278:8: warning: unused variable 'val_tree' [-Wunused-variable]
        RealD val_tree = SW_MISSING;
              ^
SW_Output.c:5281:8: warning: unused variable 'val_grass' [-Wunused-variable]
        RealD val_grass = SW_MISSING;
              ^
SW_Output.c:5279:8: warning: unused variable 'val_shrub' [-Wunused-variable]
        RealD val_shrub = SW_MISSING;
              ^
SW_Output.c:5566:8: warning: unused variable 'val' [-Wunused-variable]
        RealD val = SW_MISSING;
              ^
SW_Output.c:5675:8: warning: unused variable 'val' [-Wunused-variable]
        RealD val = SW_MISSING;
              ^
SW_Output.c:1785:13: warning: unused function 'get_outstrleader' [-Wunused-function]
static void get_outstrleader(TimeInt pd)
            ^
40 warnings generated.
BrendenBe1 added a commit that referenced this issue Apr 3, 2018
@BrendenBe1
Updating submodule to point to new commit to resolve issue #117.
f3818b2
@dschlaep
Copy link
Member Author

dschlaep commented Apr 6, 2018

As of commit 1ab301f

library("devtools")
clean_dll()
load_all()

SW_Output.c:1343:9: warning: unused variable 'reg_file_vals_week' [-Wunused-variable]
                char *reg_file_vals_week[500]; // store
                      ^
SW_Output.c:1348:9: warning: unused variable 'soil_file_vals_year' [-Wunused-variable]
                char *soil_file_vals_year[500]; // store
                      ^
SW_Output.c:1345:9: warning: unused variable 'soil_file_vals_month' [-Wunused-variable]
                char *soil_file_vals_month[500]; // store
                      ^
SW_Output.c:1349:9: warning: unused variable 'reg_file_vals_year' [-Wunused-variable]
                char *reg_file_vals_year[500]; // store
                      ^
SW_Output.c:1340:9: warning: unused variable 'reg_file_vals_day' [-Wunused-variable]
                char *reg_file_vals_day[500]; // store
                      ^
SW_Output.c:1346:9: warning: unused variable 'reg_file_vals_month' [-Wunused-variable]
                char *reg_file_vals_month[500]; // store
                      ^
SW_Output.c:1342:9: warning: unused variable 'soil_file_vals_week' [-Wunused-variable]
                char *soil_file_vals_week[500]; // store
                      ^
SW_Output.c:1339:9: warning: unused variable 'soil_file_vals_day' [-Wunused-variable]
                char *soil_file_vals_day[500]; // store
                      ^
SW_Output.c:3055:7: warning: unused variable 'delta' [-Wunused-variable]
                int delta;
                    ^
SW_Output.c:3024:6: warning: unused variable 'j' [-Wunused-variable]
        int j = 0;
            ^
SW_Output.c:3056:10: warning: unused variable 'p' [-Wunused-variable]
                RealD *p;
                       ^
11 warnings generated.

BrendenBe1 added a commit that referenced this issue Apr 6, 2018
@BrendenBe1
Resolving issue #117, all compiler warnings are gone.
217c61b
@dschlaep
Copy link
Member Author

dschlaep commented Apr 6, 2018

All good with 217c61b

@dschlaep dschlaep closed this as completed Apr 6, 2018
N1ckP3rsl3y pushed a commit that referenced this issue Jun 11, 2022
@CaitlinA
Update to unit_tests for Flow_lib functions to reflect veg arrays
5685688 
Unit tests for veg_intercepted_water and litter_intercepted_water

Issue #117
N1ckP3rsl3y pushed a commit that referenced this issue Jun 11, 2022
@CaitlinA
update to soil_temperature_init unit tests
345301f 
update to soil_temperature_init unit tests
Issue #117
N1ckP3rsl3y pushed a commit that referenced this issue Jun 11, 2022
@CaitlinA
Small change to infiltrate_water_high unit test
2dbcedb 
Issue #117
N1ckP3rsl3y pushed a commit that referenced this issue Jun 11, 2022
@dschlaep
Merge pull request #218 from DrylandEcology/Bugfix_117_Connor
acce170 
This version addressed documentation and unit testing:

User visible changes:
- Create and open documentation and user manual with `make doc doc_open`

Details:
- Documentation:
  - 'User manual' for SOILWAT2 provided as part of doxygen documentation (close #217, close #74)
  - Detailed installation instructions included in doxygen documentation (close #75)
  - Code contributor manual as part of doxygen documentation (close 86)
  - Doxygen warnings fixed (close #266)
  - Input units of biomass documented (close #265)

- Unit tests:
  - Contributed to the documentation and unit testing for all SOILWAT2 functions (see #216, see #219, see #76; close #73)
  - Unit tests for functions in `SW_Flow_lib.c` (close #117; contributed to #19)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrendenBe1 BrendenBe1

Labels
None yet
Projects
None yet
Milestone
Incorporate SOILWAT2 branch with new ...
Development

No branches or pull requests
2 participants
@dschlaep @BrendenBe1