Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

travis-ci and appveyor-ci do not use our makefile for R CMD check #81

Closed
dschlaep opened this issue Nov 30, 2017 · 2 comments
Closed

travis-ci and appveyor-ci do not use our makefile for R CMD check #81

dschlaep opened this issue Nov 30, 2017 · 2 comments
Assignees
@dschlaep
Labels
bug in progress
Milestone
Code testing

Comments

@dschlaep
Copy link
Member

The command R CMD check uses on my local machine the src/makefile and appropriate all target for checking whether package ‘rSOILWAT2’ can be installed.

However, on travis-ci and appveyor-ci, this check does not use our makefile. Instead, it uses some generic approach and compiles all source files. This includes SW_Main.c and SW_Output_mock.c which should be excluded otherwise they cause multiple definition of XXX errors.
@dschlaep dschlaep added the bug label Nov 30, 2017
@dschlaep dschlaep added this to the Rsoilwat_co2_effects milestone Nov 30, 2017
This was referenced Nov 30, 2017
Merged
Closed
@dschlaep
Copy link
Member Author

dschlaep commented Nov 30, 2017 •
edited
Loading

The problem may be related to commit DrylandEcology/SOILWAT2@2b44c05 which renamed the definition of OBJECTS to Rpkg_objects. Using Makevars in 'Writing R Extensions': "if Makevars sets ‘OBJECTS’ it will not be set on the make command line".

@dschlaep dschlaep self-assigned this Nov 30, 2017
dschlaep added a commit to DrylandEcology/SOILWAT2 that referenced this issue Nov 30, 2017
@dschlaep
Attempt to fix rSOILWAT #81
bb34a97 
- addressing issue
DrylandEcology/rSOILWAT2#81
- define 'OBJECTS' and 'SOURCES' for rSOILWAT2 compilation
dschlaep added a commit to DrylandEcology/SOILWAT2 that referenced this issue Dec 1, 2017
@dschlaep
Move rSOILWAT2 files and makefile targets to rSOILWAT2/src/
39e23c9 
- addressing DrylandEcology/rSOILWAT2#81
and DrylandEcology/rSOILWAT2#66

- Makevars, SW_R_init.c, SW_R_lib.c, and SW_R_lib.h are not used by
SOILWAT2 -- they are rSOILWAT2 files
- remove rSOILWAT2 shared object target from makefile
--> this commit requires that the removed files are added to
rSOILWAT2/src/ and that the source code of SOILWAT2 is now a submodule
in rSOILWAT2/src/SOILWAT2/ -- instead of rSOILWAT2/src/
dschlaep added a commit that referenced this issue Dec 1, 2017
@dschlaep
Move rSOILWAT2 files and makefile targets from SOILWAT2/ to rSOILWAT2…
f4327ae 
…/src/

- close #81
- addressing #66
- this rSOILWAT2 commit corresponds to SOILWAT2 commit
DrylandEcology/SOILWAT2@39e23c982c70864d9
26a0bfceec163e7fdea30b2

- Makevars, SW_R_init.c, SW_R_lib.c, and SW_R_lib.h are not used by
SOILWAT2 -- they are rSOILWAT2 files
- remove rSOILWAT2 shared object target from makefile
--> this commit requires that the removed files are added to
rSOILWAT2/src/ and that the source code of SOILWAT2 is now a submodule
in rSOILWAT2/src/SOILWAT2/ -- instead of rSOILWAT2/src/

- add all src/SOILWAT2 stuff that is not needed for rSOILWAT2 to
.Rbuildignore
@dschlaep dschlaep closed this as completed Dec 1, 2017
@dschlaep dschlaep mentioned this issue Dec 5, 2017
Merged
@dschlaep
Copy link
Member Author

dschlaep commented Dec 5, 2017

This must be fixed on master as well! Sorry for the mess that I created!

@dschlaep dschlaep reopened this Dec 5, 2017
dschlaep added a commit to DrylandEcology/SOILWAT2 that referenced this issue Dec 5, 2017
@dschlaep
Move rSOILWAT2 files and makefile targets to rSOILWAT2/src/
22e9f37 
- addressing DrylandEcology/rSOILWAT2#81
and DrylandEcology/rSOILWAT2#66

- Makevars, SW_R_init.c, SW_R_lib.c, and SW_R_lib.h are not used by
SOILWAT2 -- they are rSOILWAT2 files
- remove rSOILWAT2 shared object target from makefile
--> this commit requires that the removed files are added to
rSOILWAT2/src/ and that the source code of SOILWAT2 is now a submodule
in rSOILWAT2/src/SOILWAT2/ -- instead of rSOILWAT2/src/
N1ckP3rsl3y pushed a commit that referenced this issue Jun 11, 2022
@dschlaep
Merge pull request #98 from Burke-Lauenroth-Lab/bugfix_81-rSOILWAT2
f1fbc80 
Bugfix 81 rSOILWAT2: cherry-pick commits made on branch soilwat_co2_effects that close #81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dschlaep dschlaep

Labels
bug in progress
Projects
None yet
Milestone
Code testing
Development

No branches or pull requests
1 participant
@dschlaep