weather data use during simulations is corrupted

[dschlaep]

Commit DrylandEcology/SOILWAT2@85d2836 screwed up the weather data access during simulations.

library("rSOILWAT2")
path_demo <- system.file("extdata", "example1", package = "rSOILWAT2")
sw_in2 <- sw_inputDataFromFiles(dir = path_demo, files.in = "files.in")

The weather data are identical and present

> sw_in2@weatherHistory[[1]]@data[1:3, ]
     DOY Tmax_C Tmin_C PPT_cm
[1,]   1  -0.52 -15.67   0.22
[2,]   2  -2.06  -7.86   0.72
[3,]   3  -4.04 -14.47   0.22

Output with commit DrylandEcology/SOILWAT2@85d2836

> sw_out2 <- sw_exec(inputData = sw_in2)
WARNING: weath.1980 : Missing max temp on doy=1.
WARNING: weath.1980 : Missing min temp on doy=1.
WARNING: weath.1980 : Missing PPT on doy=1.
WARNING: weath.1980 : Missing max temp on doy=2.

Output with commit DrylandEcology/SOILWAT2@35c924a

> sw_out2 <- sw_exec(inputData = sw_in2)
> sw_out2@TEMP@Year[1:3, ]
      Year    max_C     min_C    avg_C surfaceTemp_C
 [1,] 1980 13.12448 -4.074754 4.524863             0
 [2,] 1981 14.21397 -3.032931 5.590521             0
 [3,] 1982 11.50699 -5.125288 3.190849             0
...

[dschlaep]

The problem lies in the function onSet_WTH_DATA. Eliminating the compile warnings exposed problems in the code, here testing an unused variable for a 'missing' value -- and always finding it 'missing because unused.

The question remains why this was not picked up by unit tests.