Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Fix for wrong offset values when onDoubleTapAfter is fired #61

Closed
wants to merge 1 commit into from
Closed

Fix for wrong offset values when onDoubleTapAfter is fired #61

wants to merge 1 commit into from

Conversation

ajayg415
Copy link

@ajayg415 ajayg415 commented Jun 7, 2021

This is fix for Problem statement #60

I have moved the onDoubleTapAfter into this.setState call back. this will ensure user will get correct offsetX and offsetY.

Please review, we're using this component in one of our project and this fix will help us to deliver bug free code.

Appreciate your efforts. :)

@ajayg415 ajayg415 changed the title Fix for offset values when onDoubleTapAfter is fired Fix for wrong offset values when onDoubleTapAfter is fired Jun 7, 2021
@SimonErich
Copy link
Contributor

@ajayg415 Thank you very much for your contribution.
I have checked it out, but I would like to keep the Codestructure as it is with zoomToLocation still abstracted.

Fortunately zoomToLocation was already prepared to receive a callback parameter, that will be triggered after state was changed, so I implemented it in #63 and merged it in.

With the next release onward the problem should be solved.

Thank you very much for your pull request though. I am closing it here, but only because I took your solution and implemented it differently.

@SimonErich SimonErich closed this Jun 10, 2021
@ajayg415
Copy link
Author

Thanks for your quick response @SimonErich. I thought this will become my first open source contribution, but its ok. Thanks again :)

@SimonErich SimonErich mentioned this pull request Jun 11, 2021
@SimonErich
Copy link
Contributor

Sorry @ajayg415 but keep them coming!
I really appreciated your PR. In fact your work on issues and the pr motivated me to make the take the time and make the current imrpovements on the package. :)

I would really appreciate your working help in the future as well :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants