Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeepL API and External subtitles issues #16

Open
Liqianyu opened this issue Jul 21, 2022 · 1 comment
Open

DeepL API and External subtitles issues #16

Liqianyu opened this issue Jul 21, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@Liqianyu
Copy link

Liqianyu commented Jul 21, 2022

Environment
Sugre iOS 4.20.0 TestFlight
DualSubs V0.7.x + BoxJs
tvOS 15.6

Peacock only Google Translate works, Google Cloud Translate API\Microsoft Azure Translator is not tested, DeepL API will cause infinite loading.
It seems that compatibility mode can add "Mandarin" to the UI subtitles menu, but it's the same as English (is Google Translate).

By testing against other streaming platforms, I think DeepL API unavailability is not a single platform issue.
Subtitles such as Peacock, I think, are only supported in WebVTT format. SubRip is not displayed.
hulu will still composite some lines into English if set to display only subtitles (no compositing). This can affect the display of subtitles.

@VirgilClyne VirgilClyne added the bug Something isn't working label Jul 22, 2022
@Liqianyu
Copy link
Author

Liqianyu commented Jul 22, 2022

By further testing, I think the external subtitle vtt/webvtt works fine.
There are some minor issues

  1. Even if you set only external subtitles to be displayed, the hearing-impaired auxiliary text of English CC will be displayed (not hard subtitles)
  2. The line breaks within the subtitles
    do not seem to be recognized correctly, which causes the bilingual subtitles to be displayed on one line.

If you redirect the vtt url to the subtitle file via Surge URL Rewrite, you can avoid the problem that currently exists with the module.

@Liqianyu Liqianyu changed the title Peacock only Google Translate works DeepL API and External subtitles issues Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants