Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove type definition causing DI compile issue #3

Closed
wants to merge 1 commit into from

Conversation

bsdnomad
Copy link

@bsdnomad bsdnomad commented Dec 8, 2021

Hi,

Second type def is actually not required for 2.3.6+ (suppose that also applies for all 2.3.x versions below)
Symfony\Component\VarDumper\Command\ServerDumpCommand constructor is going to be automatically handled by setup:di:compile and dependency injected properly, otherwise it always throws an exception and the command is not available when executing bin/magento or its commands

...
In ClassReader.php line 26:
                                                                                 
  Class Wiringa\DumpServer\Console\ServerDumpCommand\Interceptor does not exist  

@bsdnomad bsdnomad closed this Dec 8, 2021
@bsdnomad
Copy link
Author

bsdnomad commented Dec 8, 2021

Not working quite properly, should be tested more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant