Add TokenResponseGenerator.CreateResponseAsync #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CreateResponseAsync is a new virtual method in the TokenResponseGenerator. CreateResponseAsync does the same thing that ProcessTokenRequestAsync used to do (generate access and refresh tokens and add them to a response object), but it is called by all token flows except the refresh token flow, which generates its tokens differently. TokenResponseGenerator.ProcessTokenRequestAsync is now an alias for CreateResponseAsync and is deprecated in favor of it, with the intention to completely remove ProcessTokenRequestAsync in 7.0.
|
Ok, so let's do this:
|
But keep the refactor that unified code paths in the token response generator.
brockallen
approved these changes
Apr 1, 2023
|
@josephdecock the above text doesn't quite match anymore. |
|
Fixed! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the TokenResponseGenerator, the ProcessTokenRequestAsync method, which generates access and refresh tokens and adds them to a response object, is now called by all token flows except the refresh token flow. This unifies the programming and extensibility model of the generator, which previously had duplicated code in some flows.