When using server-side sessions, load subject from server side session store if in use #1327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bject claims from the session store rather than from the access token
josephdecock
approved these changes
Jul 7, 2023
Actually I forgot that our existing tests already have code coverage that executes this new code in this PR. That's why I didn't feel we needed any additional tests. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how the introspection endpoint works when using server side sessions. The Subject now passed to the profile service will be the ClaimsPrincipal from the server-side session store, rather than a "minimal" ClaimsPrincipal synthesized from the claims in the access token. This allows the userinfo endpoint claims generation to now access claims that are only determined as part of the user's session (in addition to anything previously accessible from the user profile store).
Closes: #1254
Closes: #884