Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename result generators #1450

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Rename result generators #1450

merged 2 commits into from
Oct 30, 2023

Conversation

josephdecock
Copy link
Member

@josephdecock josephdecock commented Oct 30, 2023

#1425 (Rename result generator)

  • Rename IEndpointResultGenerator -> IHttpResponseWriter (this is an un-released interface, so not a breaking change!)
  • IEndpointResultGenerator.ExecuteAsync -> WriteHttpResponse
  • Rename implementations of IEndpointResultGenerator, e.g., TokenResultGenerator -> TokenHttpWriter

#1446 (Allow for customization of /connect/authorize's html response)

  • Make AuthorizeHttpWriter public and add virtual methods to control its form post html output

@brockallen brockallen merged commit 4ea2f53 into main Oct 30, 2023
5 checks passed
@brockallen brockallen deleted the joe/rename-result-generators branch October 30, 2023 19:35
@josephdecock josephdecock mentioned this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants