Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework license validator to not use ConcurrentDictionary #1527

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

AndersAbel
Copy link
Member

@AndersAbel AndersAbel self-assigned this Mar 11, 2024
@AndersAbel AndersAbel changed the base branch from main to releases/7.0.x March 13, 2024 14:41
- ConcurrentDictionary has excellent concurrency performance for reading/writing
  invidivual key/values. But the locking pattern for reading the count and
  getting all keys is quite bad.
- Add tests
- Fixes #1526
@AndersAbel AndersAbel force-pushed the anders/client-validator-performance branch from f2930e2 to e03ae14 Compare March 13, 2024 14:42
@brockallen brockallen added the bug Something isn't working label Mar 14, 2024
@brockallen brockallen added this to the 7.0.2 milestone Mar 14, 2024
@brockallen brockallen merged commit f718933 into releases/7.0.x Mar 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite LicenseValidator.ValidateClient to not use ConcurrentDictionary
2 participants