Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debounce (wait msecs) option for pulse type filament monitors #176

Closed
wants to merge 2 commits into from

Conversation

rob-miller
Copy link

Add 'Wnnn' option for pulse type filament monitor to specify number of milliseconds to ignore subsequent pulses after an initial pulse is received.

Documentation change something like:

'''Additional parameters for a pulse generating filament monitor'''

  • '''Lnn''' Filament movement per pulse in mm
  • '''Wnnn''' Wait nnn milliseconds between counting pulses (debounce)
  • ''S, R, E''' As for Duet3D laser filament monitor<

…f milliseconds to ignore subsequent pulses after an initial pulse is received.

Documentation change something like:

'''Additional parameters for a pulse generating filament monitor'''

* '''Lnn''' Filament movement per pulse in mm
* '''Wnnn''' Wait nnn milliseconds between counting pulses (debounce)
* ''S, R, E''' As for Duet3D laser filament monitor
@dc42
Copy link
Collaborator

dc42 commented May 24, 2018

Please explain why you think this change is necessary. Are you using a filament motion monitor that uses a mechanical rotary encoder? Or are you using the optical rotation sensor that has a known hardware design fault?

The PIO in the SAM4 has a hardware debounce facility, and if the debounce time doesn't need to be configurable then it would be more efficient to enable it.

@rob-miller
Copy link
Author

rob-miller commented Jul 7, 2018 via email

@rob-miller rob-miller closed this May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants