Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.5 hangprinter: Allow custom and prism-like setups #603

Open
wants to merge 4 commits into
base: 3.5-dev
Choose a base branch
from
Open

3.5 hangprinter: Allow custom and prism-like setups #603

wants to merge 4 commits into from

Commits on Mar 20, 2023

  1. HangprinterKinematics::WriteCalibrationParameters: flat return style 

    Otherwise it gets too deep.
I think there's an option in eclipse to forbid this by project in
format, one can config depness iirc.
    @jtimon
    jtimon committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    d227a9c View commit details
    Browse the repository at this point in the history

  2. Hangprinter: Loop around the anchors instead of naming them directly

    @jtimon
    jtimon committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    e19697e View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2023

  1. Hangprinter: Generalize IsReachable() to any pseudo-pyramid 

    This is a clean generalization from 4 to N.
Pseudo-pyramid because the vertices in the base of the pseudo-pyramid
don't need to be on the same plane. There's no base of the pyramid as such.

Better documented and cleaner thanks to @tobbelobb on github.
    @jtimon
    jtimon committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    8300f36 View commit details
    Browse the repository at this point in the history

  2. HP: Allow custom and prism-like setups instead of just pyramid-like s… 

    …etups

- Change from bool to class and introduce None mode for
custom (experimental) setups (all allowed)

- refactor out IsInsidePyramidSides

- refactor out IsInsidePrismSides

- introduce HangprinterAnchorMode::LastOnTop for prism-like setups
  with all anchors on top

- introduce a T parameter in M666 to configure the anchor mode
    @jtimon
    jtimon committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    fd9f260 View commit details
    Browse the repository at this point in the history