Fix M260 not being able to return received data to calling macro #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In gcode M260 (i2c exchange) a parameter was added to specify the name of local variable in which received bytes will be stored. This fixes the disadvantage of not being able to return data received over the bus to the macro that invokes the gcode command.
|
I was looking to merge your changes in. However it might be better to add a new readi2c function instead, similar to the new fileread function, see https://docs.duet3d.com/en/User_manual/Reference/Gcode_meta_commands#functions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In gcode M260 (i2c exchange) a parameter was added to specify the name
of local variable in which received bytes will be stored. This fixes the
disadvantage of not being able to return data received over the bus to
the macro that invokes the M260 gcode command. Letter "V" is recommended for additional axis, so I chose the universal "S" for the name parameter. If variable name parameter is missing, the behavior remains unchanged. If variable name parameter is set, data is received and there are no errors, received data is stored in specified variable. If an error is found, the result of the gcode is changed to ERROR and the reason is reported in the reply. Possible reasons:
The test was performed on a Duet 2 WiFi board in connection with i2c sensor BME280 and eeprom m24c04.