Gemini -(Kumo) Task created in a session that has been invalidated

[gnkeshavamurthy]

DESCRIPTION

Fixing Task created in a session that has been invalidated crash

CHANGE

• Changed Service from class to actor
• Updated perform() with async & await

[powerje]

Had some questions about the changes

[powerje]

Is this still calling a function on the service somehow?

[gnkeshavamurthy]

yes, I have added a method to call service.perform as we have to use Task {} for this call

         Task {
                    do {
                        let result: T = try await service.perform(request)
                        promise(.success(result))
                    } catch let error {
                        promise(.failure(error))
                    }
                }

so I'm using that common method in tests

[powerje]

Running the tests ($ swift test) there are some warnings:

Service.swift:285:10: note: calls to instance method 'downloadResultToURL(url:response:)' from outside of its actor context are implicitly asynchronous
    func downloadResultToURL(url: URL?, response: URLResponse?) throws -> URL {
...
 warning: non-sendable type 'OperationQueue?' passed in call to nonisolated initializer 'init(baseURL:runsInBackground:logger:delegateQueue:configuration:)' cannot cross actor boundary
    let service = Service(baseURL: URL(string: "https://httpbin.org")!, logger: TestLogger())
...
Swift.Optional:1:21: note: generic enum 'Optional' does not conform to the 'Sendable' protocol
@frozen public enum Optional<Wrapped> : ExpressibleByNilLiteral {

I think we should address these?

[gnkeshavamurthy]

Running the tests ($ swift test) there are some warnings:

Service.swift:285:10: note: calls to instance method 'downloadResultToURL(url:response:)' from outside of its actor context are implicitly asynchronous
    func downloadResultToURL(url: URL?, response: URLResponse?) throws -> URL {
...
 warning: non-sendable type 'OperationQueue?' passed in call to nonisolated initializer 'init(baseURL:runsInBackground:logger:delegateQueue:configuration:)' cannot cross actor boundary
    let service = Service(baseURL: URL(string: "https://httpbin.org")!, logger: TestLogger())
...
Swift.Optional:1:21: note: generic enum 'Optional' does not conform to the 'Sendable' protocol
@frozen public enum Optional<Wrapped> : ExpressibleByNilLiteral {

I think we should address these?

Fixed this warning