Remove invalidation while session is valid. #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempting to set: `invalidations[session] = nil` would sometimes crash due to bad memory access, presumably because the invalidation closure has run and the session is no longer valid. This update grabs the invalidation closure, then removes it from the map, then calls the closure to invalidate.
|
Eh not sure this really did anything useful, once the session is gone, it's gone |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to set:
invalidations[session] = nilwould sometimes crash due to bad memory access, presumably because the invalidation closure has run and the session is no longer valid.This update grabs the invalidation closure, then removes it from the map, then calls the closure to invalidate.