Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement other docker runtime features #11

Open
dleehr opened this issue Jan 9, 2019 · 2 comments
Open

Implement other docker runtime features #11

dleehr opened this issue Jan 9, 2019 · 2 comments
Labels
good first issue Good for newcomers

Comments

@dleehr
Copy link
Member

dleehr commented Jan 9, 2019

As noted in

# TODO: Determine if we can port --read-only, networkaccess, log-driver, --user

DockerCommandLineJob.create_runtime() builds up some additional docker command flags (read-only container filesystem, custom network access, matching user, etc)

Some of these may be necessary/appropriate. Should research/triage/implement as needed

@dleehr
Copy link
Member Author

dleehr commented Mar 7, 2019

In some cases these arguments map to CWL features (network access), and in some cases they're not achievable on openshift without changing security contexts (--user). I think the first order of business is to document that calrissian does not support these CWL goals/features, but welcome contributions to address them.

@dleehr dleehr added the good first issue Good for newcomers label Mar 7, 2019
@mr-c
Copy link
Contributor

mr-c commented Jul 22, 2019

Running with --user is good to catch containers that require that the root user be used. It probably isn't necessary as long as you manage the file permissions (if needed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants