Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support additional DockerRequirements where possible #12

Open
dleehr opened this issue Jan 10, 2019 · 3 comments
Open

Support additional DockerRequirements where possible #12

dleehr opened this issue Jan 10, 2019 · 3 comments

Comments

@dleehr
Copy link
Member

dleehr commented Jan 10, 2019

This method assumes a DockerRequirement with dockerPull, and will fail otherwise:

def _get_container_image(self):
# we only use dockerPull here
# Could possibly make an API call to kubernetes to check for the image there, but that's not important right now
(docker_req, docker_is_req) = self.get_requirement("DockerRequirement")
return str(docker_req["dockerPull"])

Related to #7, which would inject a DockerRequirement prior to this call

@dleehr dleehr changed the title Improve image name resolution of job._get_container_image() Support additional DockerRequirements where possible Jan 24, 2019
@dleehr
Copy link
Member Author

dleehr commented Jan 24, 2019

List of CWL DockerRequirements: https://www.commonwl.org/v1.0/CommandLineTool.html#DockerRequirement

Currently we only need/use dockerPull, but the others should be supported where possible

@dleehr
Copy link
Member Author

dleehr commented Jan 24, 2019

dockerOutputDirectory is one of these requirements, closing #10 to consider it here.

@dleehr
Copy link
Member Author

dleehr commented Mar 7, 2019

Also of note, #35 implements checking of the specified docker requirements and fails if they are not supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant