Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to python3 #18

Merged
merged 9 commits into from
Jul 2, 2019
Merged

Upgrade to python3 #18

merged 9 commits into from
Jul 2, 2019

Conversation

johnbradley
Copy link
Contributor

@johnbradley johnbradley commented Jun 27, 2019

Changes:

NOTE:
The deployed Docker image contains both python3 and python2. Ideally this would just contain python3. This repo runs some CWL workflows that are based on external repositories that are not upgraded to python3:

iMADS-worker/Dockerfile

Lines 36 to 45 in fffd8a4

### Step 3: Install Predict-TF-Binding from GitHub
WORKDIR /opt/
RUN git clone https://github.com/Duke-GCB/Predict-TF-Binding.git predict-tf-binding
RUN pip install -r /opt/predict-tf-binding/requirements.txt
ENV PATH /opt/predict-tf-binding/:$PATH
### Step 4: Install Predict-TF-Preference from GitHub
WORKDIR /opt/
RUN git clone https://github.com/Duke-GCB/Predict-TF-Preference.git predict-tf-preference
ENV PATH /opt/predict-tf-preference/:$PATH

Fixes #15
Fixes #17

This is currently deployed/tested on http://imads-dev.gcb.duke.edu.

Copy link
Member

@dleehr dleehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Created Duke-GCB/Predict-TF-Binding#45 and Duke-GCB/Predict-TF-Preference#4 to upgrade those projects to Python 3

@johnbradley johnbradley merged commit b06ca0b into master Jul 2, 2019
@johnbradley johnbradley deleted the 15-python3 branch July 2, 2019 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pyyaml vulnerability Upgrade to python 3
2 participants