This repository has been archived by the owner on Oct 27, 2022. It is now read-only.
DDS-974 enforce upload chunk size #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- chunk_max_number: integer - chunk_max_size_bytes:integer
- :chunk_max_number - :chunk_max_size_byte StorageProvider meets spec :storage_providers factory creates storage_provider with these values set for both default and :swift swift.local.env sets these to standard values
…oo large for int, uses a bigint instead
…ber and max_chunk_size_bytes expects ENV to be set accordingly only if there are bad storage providers
…rialize StorageProvider with chunk_max_number and chunk_max_size_bytes StorageProviderSerializer meets spec
added deployment notes
- implement max_size_bytes (storage_provider.chunk_max_number * storage_provider.chunk_max_size_bytes)
- validate that size is_less_than max_size_bytes
- implement minimum_chunk_size ((size.to_f / storage_provider.chunk_max_number).ceil)
Upload meets spec
Chunks Factory creates Chunks with size between a sensible range
ChunkSpec expects Chunk to:
- delegate chunk_max_size_bytes to storage_provider
- delegate minimum_chunk_size to upload
- validate size
- presence
- < chunk_max_size_bytes
- >= minimum_chunk_size
- produce custom validation message
Chunk meets spec
- implement total_chunks method which returns the current number of upload.chunks
- validate that a chunk must not increase the total_chunks beyond the
storage_provider.chunk_max_number
Chunk meets spec
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.