fix: Room not found

[MJinH]

Fixes Issue

**My PR closes #577 **

👨‍💻 Changes proposed(What did you do ?)

1. commented out the lines in anonymous.tsx file. Had an issue where the socket would connect on the server side but immediately disconnect on the client side, which was causing the NEW_EVENT_CHAT_RESTORE event to not work properly.

2. After debugging, noticed that the createChat function wasn't being called properly in the anonymous.tsx file. suspect this was because it was being called before the provider was initialized, so wrapped the components with ChatProvider in the _app.tsx file and confirmed that it was working correctly.

✔️ Check List (Check all the applicable boxes)

• My code follows the code style of this project.
• This PR does not contain plagiarized content.
• The title and description of the PR is clear and explains the approach.

Note to reviewers

📷 Screenshots

[vercel]

Someone is attempting to deploy a commit to a Personal Account owned by @Dun-sin on Vercel.

@Dun-sin first needs to authorize it.

[github-actions]

PR Compliance Checks Passed!

[Dun-sin]

Will review this later in the day @MJinH in the mean time, please remove the package files, don't delete them but remove them from your PR. Thanks

[Dun-sin]

Leave the naming

[Dun-sin]

Please remove everything that doesn't have to do with the issue, like changing name or formatting?

Also why are you calling context twice as we've already called it in PageWrapper.tsx, so either you remove it from there and leave your changes or vice versa, but can't be both

[MJinH]

Could you please check this? in the ChatContext.tsx file, when the name is "chatId" in the createChat, it seems to result in 'undefined' in the chatReducer as shown in the image. When using 'id', it looks like it's assigned correctly. Please let me know if i missed something. Also, yes you're right. I forgot to remove the context in the PageWrapper.tsx file.

[Dun-sin]

Could you please check this? in the ChatContext.tsx file, when the name is "chatId" in the createChat, it seems to result in 'undefined' in the chatReducer as shown in the image. When using 'id', it looks like it's assigned correctly. Please let me know if i missed something. Also, yes you're right. I forgot to remove the context in the PageWrapper.tsx file.

i guess the issue comes from here:
remove the ID and leave the chat Id, should fix it, can't believe i missed that
making it, also i would prefer the provider to be the in the pageWrapper:

chatId,

not this👇

Whisper/src/reducer/chatReducer.ts

Line 24 in 94b3b50

id: chatId,

[MJinH]

got it, and if the provider is in PageWrapper, the createChat in anonymous.tsx doesn't seem to be called properly. When debugging, it gets called as createChat: () => {} and exits immediately. can you please check this as well?

I'll fix those and recommit later. Thank you.

[Dun-sin]

Also @MJinH what exactly do you mean in Anonmyous.tsx?

[MJinH]

What I mean is, when ChatProvider is in PageWrapper, createChat is exeucted like this
room-1.webm

and this is when the provider is in _app.tsx

[Dun-sin]

What I mean is, when ChatProvider is in PageWrapper, createChat is exeucted like this
room-1.webm

and this is when the provider is in _app.tsx

I see your point, yours is a better way then💪🏽 but the other things still count

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
whisper	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 6, 2024 7:45am

[Dun-sin]

You did great, thanks for contributing, I hope you will stick around and continue to contribute to this project.

Consider giving this project a star and joining the community discord server if you haven't for more resources and opportunities to connect with others. 👉🏽here👈🏽