[IGNORE] Enable CI for Gemstone and correct missing compatibility #190
Conversation
Pull Request Test Coverage Report for Build 343
💛 - Coveralls |
|
@pdebruic The only failures that are still here are linked to OrderedDictionary and its subclass. Can you take a look please? |
|
Also would you wind if I move this project to DuneSt? I do not like the fact that it loads one package from a different repo without versionning. I would like to make it a versionned project on which peolpe can do PR. Same for the PackageManifest. |
|
Can you provide a link to the failures? Are they not explained by the commit message for the OrderedDictionary package?
… On Jul 9, 2018, at 6:41 AM, CyrilFerlicot ***@***.***> wrote:
@pdebruic The only failures that are still here are linked to OrderedDictionary and its subclass.
Can you take a look please?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
I don't think this package is at all seaside specific. Why do you want to clutter your new seaside additions group with this? Also limits discoverability from GS perspective. Might be better in e.g. github.com/gsdevkit
Maybe instead you can add the classes MDL & MDLColor require to the Baseline of the pharo compatability package you found, and load it from there.
But I think moving it anywhere is fine. MIT and all.
… On Jul 9, 2018, at 7:09 AM, CyrilFerlicot ***@***.***> wrote:
Also would you wind if I move this project to DuneSt? I do not like the fact that it loads one package from a different repo without versionning.
I would like to make it a versionned project on which peolpe can do PR. Same for the PackageManifest.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@pdebruic I just read the message and yes this explains the failures. I'll try to change the tests to not fail the build and also as I said if it's fine with you I move the OrderedDictionary to this project: https://github.com/DuneSt/OrderedDictionary Like that, I'll be able to keep semantic versioning without problem. |
|
Also are you able to develop on GemStone yet? If not it seems strange to move GS specific packages around until you can and have time to maintain it. But again, I don't have a problem with you doing whatever you want with the GS specific OrderedDictionary classes or PackageManifest stub.
… On Jul 9, 2018, at 7:09 AM, CyrilFerlicot ***@***.***> wrote:
Also would you wind if I move this project to DuneSt? I do not like the fact that it loads one package from a different repo without versionning.
I would like to make it a versionned project on which peolpe can do PR. Same for the PackageManifest.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
The problem is that I'm not part of gsdevkit. I'll ask Dale if he can add me and in that case, yes I'll add the projects to this organisation. |
|
I could install Gemstone on a VirtualMachine. It's still pretty new to me but at least with that and the CI I'm able to do some things :) I could not install MDL and launch the demo... But at least I can browse the code and check the tests. |
|
@pdebruic I sent a mail to Dale asking to be added to the organisation. |
|
Sounds great to me. Glad you were able to get GemStone running.
… On Jul 9, 2018, at 8:08 AM, CyrilFerlicot ***@***.***> wrote:
@pdebruic I sent a mail to Dale asking to be added to the organisation.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
I got the rights on GsDevKit organization. I'll finish this release just after ESUG :) |
Since MDL is a seaside framework it should not use any OS dependent stuff. Thus it should be fine to not test OSX. It will reduce the chance of random failure this may.
Still not working for now:
Executed 569 Tests with 4 Failures and 3 Errors in 0.10s.