Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1.3.1 - Deprecation before major release #200

Merged
merged 8 commits into from
Oct 17, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# [v1.3.1](https://github.com/DuneSt/MaterialDesignLite/compare/v1.3.0...v1.3.1) (2018-10-18)

* This release brings a lot of deprecation in prevision of the next major release.

# [v1.3.0](https://github.com/DuneSt/MaterialDesignLite/compare/v1.2.0...v1.3.0) (2018-10-07)

## Features
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
tests
testBareBrush
self assert: [ :html | html mdlCardTitle ] generates: '<div class="mdl-card__title"></div>'
self
assert: [ :html | html mdlCardTitleContainer ]
generates: '<div class="mdl-card__title"></div>'
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
tests
testBorder
self assert: [ :html | html mdlCardTitle border ] generates: '<div class="mdl-card__title mdl-card--border"></div>'
self
assert: [ :html | html mdlCardTitleContainer border ]
generates: '<div class="mdl-card__title mdl-card--border"></div>'
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
tests
testExpand
self assert: [ :html | html mdlCardTitle expand ] generates: '<div class="mdl-card__title mdl-card--expand"></div>'
self
assert: [ :html | html mdlCardTitleContainer expand ]
generates: '<div class="mdl-card__title mdl-card--expand"></div>'
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
tests
testWithContent
self assert: [ :html | html mdlCardTitle: [ html mdlCardTitleText: 'test' ] ] generates: '<div class="mdl-card__title"><h1 class="mdl-card__title-text">test</h1></div>'
self
assert: [ :html | html mdlCardTitleContainer: [ html mdlCardTitleText: 'test' ] ]
generates:
'<div class="mdl-card__title"><h1 class="mdl-card__title-text">test</h1></div>'

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
tests
testBareBrush
self assert: [ :html | html mdlMultilineTextField ] generates: '<textarea rows="auto" cols="auto" class="mdl-textfield__input"></textarea>'.
self assert: [ :html | html brush: MDLMultilineTextField new ] generates: '<textarea rows="auto" cols="auto" class="mdl-textfield__input"></textarea>'
self
assert: [ :html | html mdlTextArea ]
generates:
'<textarea rows="auto" cols="auto" class="mdl-textfield__input"></textarea>'.
self
assert: [ :html | html brush: MDLMultilineTextField new ]
generates:
'<textarea rows="auto" cols="auto" class="mdl-textfield__input"></textarea>'
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
tests
testWithContent
self assert: [ :html | html mdlMultilineTextField: 'Test' ] generates: '<textarea rows="auto" cols="auto" class="mdl-textfield__input">Test</textarea>'.
self assert: [ :html | (html brush: MDLMultilineTextField new) with: 'Test' ] generates: '<textarea rows="auto" cols="auto" class="mdl-textfield__input">Test</textarea>'
self
assert: [ :html | html mdlTextArea: 'Test' ]
generates:
'<textarea rows="auto" cols="auto" class="mdl-textfield__input">Test</textarea>'.
self
assert: [ :html | (html brush: MDLMultilineTextField new) with: 'Test' ]
generates:
'<textarea rows="auto" cols="auto" class="mdl-textfield__input">Test</textarea>'
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
deprecation
isDeprecated
"Use #beGrid on a section brush."

^ true
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
options
disable
self deprecated: 'Use #disabled instead' transformWith: '`@receiver disable' -> '`@receiver disabled'.
self disabled
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
*Material-Design-Lite-Components
mdlCardTitle: aBlock
^ self mdlCardTitle
with: aBlock;
yourself
self deprecated: 'Use #mdlCardTitleContainer: instead.' transformWith: '`@receiver mdlCardTitle: `@statements' -> '`@receiver mdlCardTitleContainer: `@statements'.
^ self mdlCardTitleContainer: aBlock
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
*Material-Design-Lite-Components
mdlCardTitle
^ self brush: MDLCardTitleContainer new
self deprecated: 'Use #mdlCardTitleContainer instead.' transformWith: '`@receiver mdlCardTitle' -> '`@receiver mdlCardTitleContainer'.
^ self mdlCardTitleContainer
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
*Material-Design-Lite-Components
mdlCardTitleContainer: aBlock
^ self mdlCardTitleContainer
with: aBlock;
yourself
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
*Material-Design-Lite-Components
mdlCardTitleContainer
^ self brush: MDLCardTitleContainer new
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
*Material-Design-Lite-Components
mdlGridSection: aBlock
self deprecated: 'Use #beGrid of a section brush'.
^ self mdlGridSection
with: aBlock;
yourself
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
*Material-Design-Lite-Components
mdlGridSection
self deprecated: 'Use #beGrid on a section brush'.
^ self brush: MDLGridSection new
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
accessing
applicationName: aName
self deprecated: 'This is not used in MDL application. Please implement your own variable if you need this'.
applicationName := aName
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
accessing
applicationName
self deprecated: 'This is not used in MDL application. Please implement your own variable if you need this'.
^ applicationName
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
accessing
description
^ 'A calendar in Material Design style'
^ 'A calendar in Material Design style to pick a date'
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
accessing
title
^ 'Calendar'
^ 'Date Picker'

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
sections
datePicker
^ OrderedDictionary new
add: 'Date picker' -> #renderDatePickerOn:;
yourself
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
sections
flatDatePicker
^ OrderedDictionary new
add: 'Flat date picker' -> #renderFlatDatePickerOn:;
yourself
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
demos
renderCalendarCardOn: html
renderDatePickerOn: html
html
render:
(MDLCalendarCardWidget new
(MDLDatePicker new
callback: [ :day | selectedDay := day ];
currentDate: selectedDay;
onCompleteScript: ((html jQuery id: 'selectedDay2') load html: [ :r |
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
demos
renderCalendarOn: html
renderFlatDatePickerOn: html
html div
style: 'background-color: white;border: 1px grey solid;';
with:
(MDLCalendarWidget new
(MDLFlatDatePicker new
callback: [ :day | selectedDay := day ];
currentDate: selectedDay;
onCompleteScript: ((html jQuery id: 'selectedDay') load html: [ :r |
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
rendering
renderScreenContentOn: html
self
render: self calendar on: html;
render: self calendarCard on: html
render: self datePicker on: html;
render: self flatDatePicker on: html
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ renderDateCardOn: html
mdlTypographyTextLeft;
style: 'width: 256px; height: 256px; background: #3E4EB8;';
with: [
html mdlCardTitle
html mdlCardTitleContainer
style: 'align-items: flex-start; color: #fff';
expand;
with: [ html mdlCardTitleText
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ renderImageCardOn: html
mdlTypographyTextLeft;
style: 'width: 256px; height: 256px; background: url(''' , (MDLDemoLibrary urlOf: #imagecardJpg) asString , ''') center / cover';
with: [
html mdlCardTitle expand.
html mdlCardTitleContainer expand.

html mdlCardActions
style: 'height: 52px; padding: 16px; background: rgba(0,0,0,0.2)';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ renderSquareCardOn: html
mdlTypographyTextLeft;
style: 'width: 320px; height: 320px';
with: [
html mdlCardTitle
html mdlCardTitleContainer
expand;
style: 'color: #fff;background: url(''' , (MDLDemoLibrary urlOf: #dogPng) asString , ''') bottom right 15% no-repeat #46B6AC;';
with: [ html mdlCardTitleText: 'Update' level: 2 ].
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ renderWideCardOn: html
mdlTypographyTextLeft;
style: 'width: 512px';
with: [
html mdlCardTitle
html mdlCardTitleContainer
style: 'height: 176px; background: url(''' , (MDLDemoLibrary urlOf: #welcomecardJpg) asString , ''') center / cover; color: #fff';
with: [ html mdlCardTitleText: 'Welcome' ].

Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
versions
version
^ 'v1.3.0'
^ 'v1.3.1'
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,5 @@ SystemOrganization addCategory: 'Material-Design-Lite-Demo-Components'!
SystemOrganization addCategory: 'Material-Design-Lite-Demo-Core'!
SystemOrganization addCategory: 'Material-Design-Lite-Demo-Extensions'!
SystemOrganization addCategory: 'Material-Design-Lite-Demo-Utils'!
SystemOrganization addCategory: #'Material-Design-Lite-Demo-Widgets'!
SystemOrganization addCategory: 'Material-Design-Lite-Demo-Widgets'!
ets'!
SystemOrganization addCategory: #'Material-Design-Lite-Demo-Widgets'!
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
running
setUp
super setUp.
calendar := MDLCalendarWidget new
calendar := MDLDatePicker new
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,3 @@ SystemOrganization addCategory: #'Material-Design-Lite-Widgets-Tests-Menu'!
SystemOrganization addCategory: #'Material-Design-Lite-Widgets-Tests-Poll'!
SystemOrganization addCategory: #'Material-Design-Lite-Widgets-Tests-Tab'!
SystemOrganization addCategory: #'Material-Design-Lite-Widgets-Tests-Table'!
ystemOrganization addCategory: #'Material-Design-Lite-Widgets-Tests-Table'!
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Calendar widget in a card
Please use MDLDatePicker instead.
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
deprecation
isDeprecated
"Please use MDLDatePicker instead."

^ true
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"commentStamp" : "ThomasHeniart 6/14/2016 15:26",
"super" : "MDLCalendarWidget",
"commentStamp" : "CyrilFerlicot 10/17/2018 23:26",
"super" : "MDLDatePicker",
"category" : "Material-Design-Lite-Widgets-Calendar",
"classinstvars" : [ ],
"pools" : [ ],
Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Widget to basically display a calendar with MDL style
Please use MDLFlatDatePicker instead.
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
deprecation
isDeprecated
"Please use MDLFlatDatePicker instead."

^ true
Original file line number Diff line number Diff line change
@@ -1,16 +1,11 @@
{
"commentStamp" : "ThomasHeniart 6/8/2016 10:55",
"super" : "MDLHighLevelWidget",
"commentStamp" : "CyrilFerlicot 10/17/2018 23:25",
"super" : "MDLFlatDatePicker",
"category" : "Material-Design-Lite-Widgets-Calendar",
"classinstvars" : [ ],
"pools" : [ ],
"classvars" : [ ],
"instvars" : [
"daysList",
"calendar",
"callback",
"onCompleteScript"
],
"instvars" : [ ],
"name" : "MDLCalendarWidget",
"type" : "normal"
}
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
rendering
renderContentOn: html
| brush |
brush := html mdlCardTitle.
brush := html mdlCardTitleContainer.
self addPropertiesToBrush: brush.
brush with: [ html mdlCardTitleText: self title level: self level ]
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
I am a date picker embebded in a MDLCard for a better display.
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"commentStamp" : "CyrilFerlicot 10/17/2018 23:24",
"super" : "MDLFlatDatePicker",
"category" : "Material-Design-Lite-Widgets-Calendar",
"classinstvars" : [ ],
"pools" : [ ],
"classvars" : [ ],
"instvars" : [ ],
"name" : "MDLDatePicker",
"type" : "normal"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
I am a component displaying a calendar to let the user pick a date.
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ renderCurrentMonthOn: html
tablet: 6
phone: 2
with: [ self
renderButtonNamed: self currentDate monthName
renderButtonNamed: self currentDate monthAbbreviation
renderingMethod: #renderMonthesOn:
on: html.
html space.
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
{
"commentStamp" : "CyrilFerlicot 10/17/2018 23:23",
"super" : "MDLHighLevelWidget",
"category" : "Material-Design-Lite-Widgets-Calendar",
"classinstvars" : [ ],
"pools" : [ ],
"classvars" : [ ],
"instvars" : [
"daysList",
"calendar",
"callback",
"onCompleteScript"
],
"name" : "MDLFlatDatePicker",
"type" : "normal"
}
Loading