Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the code so that it works with Django 1.10rc1 #8

Merged
merged 2 commits into from Jul 27, 2016

Conversation

ataylor32
Copy link
Contributor

The change to "lockdown/middleware.py" is explained in the "dictionary and context_instance arguments of rendering functions" section of the Django 1.8 release notes.

The change to "lockdown/tests/test_settings.py" is explained here.

TEMPLATES = [
{
'BACKEND': 'django.template.backends.django.DjangoTemplates',
'DIRS': [],
Copy link
Owner

@Dunedan Dunedan Jul 27, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An empty list is the default for DIRS, therefore this option isn't necessary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dunedan
Copy link
Owner

Dunedan commented Jul 27, 2016

Thanks for that contribution. Coincidentally I already had a local branch with these changes for Django 1.10, but good to know that somebody else cares about that as well. 😄

I added one inline comment for a minor clean up. It'd be great if you could change that before I merge it.

Another thing I noticed with 1.10 are the deprecation warnings for the changes to the middleware handling. I haven't found the time to adjust that for django-lockdown so that it works for all supported Django versions. If that's something interesting for you, you could tackle that as well.

My current plan is to release a new version once Django 1.10 is out, whose new features would be your previous pull request (#7) and the support for Django 1.10.

@ataylor32
Copy link
Contributor Author

You're welcome! Ah, I was thinking you might have already been planning to update the code to work with Django 1.10. I probably should have asked first 😃

I removed the 'DIRS': [], line.

@Dunedan Dunedan merged commit 4bdc336 into Dunedan:master Jul 27, 2016
@dedsm
Copy link

dedsm commented Aug 6, 2016

hey! any planned time for that release? :)

@Dunedan
Copy link
Owner

Dunedan commented Aug 6, 2016

I'll try to get it out later today or tomorrow.

@dedsm
Copy link

dedsm commented Aug 6, 2016

thanks @Dunedan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants