Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audio input & output is working for MBP 13,3 and 14,3 #149

Merged
merged 1 commit into from
Jul 20, 2020
Merged

Audio input & output is working for MBP 13,3 and 14,3 #149

merged 1 commit into from
Jul 20, 2020

Conversation

andyholst
Copy link
Contributor

Internal audio and microphone is working when applying the Cirrus 8409
patch from https://github.com/davidjo/snd_hda_macbookpro for kernel
version 5.5+.

@andyholst
Copy link
Contributor Author

@Dunedan PR created.

@divad42
Copy link

divad42 commented Jun 18, 2020

This patch works for the 14,3 model as well (tested on Parabola Linux with linux-libre kernel version 5.7.2-gnu-1).

@AndreasAZiegler
Copy link

Did somebody already checked if this works for 15,1 models too?

@andyholst
Copy link
Contributor Author

andyholst commented Jun 20, 2020 •
edited
Loading

@divad42 @AndreasAZiegler this patch should work for MBP 13,1 MBP 13,2 MBP 13,3 and MBP 14,3 https://bugzilla.kernel.org/show_bug.cgi?id=195671

@andyholst andyholst force-pushed the mbp_13_3_internal_audio_mic_support branch 2 times, most recently from 720b22a to 3166364 Compare June 20, 2020 07:23
@andyholst
Copy link
Contributor Author

andyholst commented Jun 20, 2020 •
edited
Loading

@divad42 can you provide me the related hwinfo and dmesg information for MBP 14,3 model so I can update the commit with that information as well?

@Dunedan
Copy link
Owner

Dunedan commented Jun 21, 2020

Thanks for this PR. I'll leave it open for a bit to let you sort out the supported models.

@andyholst andyholst force-pushed the mbp_13_3_internal_audio_mic_support branch from 3166364 to f6be762 Compare June 21, 2020 16:46
This was referenced Jun 21, 2020
Closed
Closed
@andyholst andyholst force-pushed the mbp_13_3_internal_audio_mic_support branch from f6be762 to d06bb2f Compare June 21, 2020 17:20
This was referenced Jun 21, 2020
Open
Closed
@andyholst
Copy link
Contributor Author

andyholst commented Jun 21, 2020 •
edited
Loading

Thanks for this PR. I'll leave it open for a bit to let you sort out the supported models.

@Dunedan I have informed all the authors of the related MBP >= 13.1 models internal audio & microphone issues to provide the related dmesg and hwinfo information by the commands dmesg | nc termbin.com 9999 and hwinfo | nc termbin.com 9999 and provide me the links so I can copy it.

@andyholst andyholst mentioned this pull request Jun 21, 2020
Closed
@divad42
Copy link

divad42 commented Jun 21, 2020

https://termbin.com/ig9z
https://termbin.com/q9uh
@MrAsimov

@andyholst andyholst force-pushed the mbp_13_3_internal_audio_mic_support branch from d06bb2f to 6c51b9b Compare June 21, 2020 23:44
@andyholst
Copy link
Contributor Author

andyholst commented Jun 21, 2020 •
edited
Loading

@divad42 Thank you for sharing, I have added the dmesg and hwinfo information to the MBP 14,3 section and updated the README.md accordingly.

@andyholst andyholst force-pushed the mbp_13_3_internal_audio_mic_support branch from 6c51b9b to 709d202 Compare June 22, 2020 00:21
@andyholst andyholst changed the title Internal audio & mic. is working for MBP13,3 Internal audio input & output is working for MBP 13,3 and 14,3 Jun 22, 2020
@andyholst andyholst force-pushed the mbp_13_3_internal_audio_mic_support branch from 709d202 to e10756f Compare June 22, 2020 01:04
@tbzatek
Copy link

tbzatek commented Jun 22, 2020

I've got the sound working on MacBookPro14,1 by using the sources from https://github.com/davidjo/snd_hda_macbookpro. There are some random glitches there and there but by keeping the output open and using ALSA dmix and softvol plugins it works quite fine. Jack detection works randomly, usually stops working after few unplug cycles. Still a great improvement though!

Haven't tested the microphone yet.

hwinfo-MacBookPro14,1.txt

dmesg-MacBookPro14,1.txt

@andyholst
Copy link
Contributor Author

andyholst commented Jun 22, 2020 •
edited
Loading

@tbzatek Can you test the microphone? I have no intention to mention that MBP 14,1 works if input does not work, if that works somewhat, I will say it works partiallly.

Can you try and see if you have any better luck with pulseaudio with your Gentoo distro?

Thanks

@andyholst andyholst force-pushed the mbp_13_3_internal_audio_mic_support branch 2 times, most recently from 603da09 to 544c309 Compare June 22, 2020 18:21
@andyholst andyholst changed the title Internal audio input & output is working for MBP 13,3 and 14,3 Audio input & output is working for MBP (>= 13,3) Jun 22, 2020
@tbzatek
Copy link

tbzatek commented Jun 23, 2020

@tbzatek Can you test the microphone? I have no intention to mention that MBP 14,1 works if input does not work, if that works somewhat, I will say it works partiallly.

Audio input doesn't seem to work, sox is having trouble opening an input device, or it gets stuck. Don't have a combined headphone+mic headset here. Don't see a mixer input element either (with empty .asoundrc config).

Can you try and see if you have any better luck with pulseaudio with your Gentoo distro?

Pulseaudio is essentially just a layer on top of ALSA, there's no point of testing it.

As noted in the snd_hda_macbookpro it's just a first dirty PoC that somehow enables the device. There are many issues currently, namely:

  • opening a playback device node sometimes result in constant high pitch tone (2~3 kHz), sometimes the audio is distorted and garbled, sometimes you get clean sound (in about 30% of cases)
  • jack detection works randomly
  • no HW volume control
  • no HW mixing
  • possibly limited to 2ch@44.1 kHz format
  • input/microphone support is unknown

Some of the limitations can be worked around by userspace software mixing solution, such as dmix, pulseaudio or jack.

The difference from vanilla kernel state is that you can sometimes get some sound, comparing to complete silence when unpatched. I've been successfully listening to music and that counts. I would label the support as "experimental" or "very limited".

@andyholst
Copy link
Contributor Author

andyholst commented Jun 23, 2020 •
edited
Loading

@tbzatek thanks, I will set it to partially working. I recommend you report your findings for your MBP 14,1 model at davidjo/snd_hda_macbookpro#6 I have read that they got internal mic and sound working for the 14,1 model.

@andyholst
Copy link
Contributor Author

andyholst commented Jun 24, 2020 •
edited
Loading

@divad42 Just to be sure, you got internal input (mic.) working for 14,3?

@divad42
Copy link

divad42 commented Jun 25, 2020 via email

@andyholst
Copy link
Contributor Author

andyholst commented Jun 25, 2020 •
edited
Loading

@divad42 To bad. So MBP 13,3 model is the only model where the internal mic is fully working with the https://github.com/davidjo/snd_hda_macbookpro driver patch for kernel version 5.5. Interesting. Updating the README.md file again.

@andyholst andyholst force-pushed the mbp_13_3_internal_audio_mic_support branch 4 times, most recently from ddd5f68 to 0494179 Compare June 25, 2020 14:53
@andyholst andyholst changed the title Audio input & output is working for MBP (>= 13,3) Audio input & output is working for MBP 13,3 Jun 25, 2020
@andyholst andyholst force-pushed the mbp_13_3_internal_audio_mic_support branch 4 times, most recently from 7198ae0 to 179e973 Compare June 28, 2020 03:56
@andyholst
Copy link
Contributor Author

andyholst commented Jun 28, 2020 •
edited
Loading

@Dunedan I don't think I can gather more dmesg and hwinfo information for the other MacBook Pro models (>= 13,1 or <= 16,1) after organizing the other issue creators of the past MacBook Pro audio issues related to this pull request. I am waiting for your review and is standing by for any suggestions of 'better' README documentation etc.

@andyholst
Copy link
Contributor Author

andyholst commented Jun 30, 2020 •
edited
Loading

The internal audio input is working for MacBook Pro model 14,3 by using the kernel version 5.5+ confirmed at davidjo/snd_hda_macbookpro#12 , the mic 'hiccups' can be resolved by switching the 'right' built-in audio profile and see if its recognizing the background sound with help of the pavucontrol command if you are using pulse audio; it should work on 'Analog Stereo Duplex' built-in audio profile. It is documented in the README.md file.

Audio is working for MBP 13,3 and 14,3
da9ebd9 
Audio input and output is working for MacBook Pro models 13,3 and 14,3
when applying the Cirrus 8409 driver patch from
https://github.com/davidjo/snd_hda_macbookpro
(commit 86c032bcbc27d12c819841c05b5a484477869481) for kernel version
5.5+.

The internal audio output is working for MacBook Pro models 14,1 with
the Cirrus 8409 driver patch for kernel version 5.5+.

Added dmesg and hwinfo information for MacBook Pro models 13,3; 14,1
and 14,3 and updated the README.md accordingly for the audio input &
output section.
@andyholst andyholst force-pushed the mbp_13_3_internal_audio_mic_support branch from 179e973 to da9ebd9 Compare June 30, 2020 02:23
@andyholst andyholst changed the title Audio input & output is working for MBP 13,3 Audio input & output is working for MBP 13,3 and 14,3 Jun 30, 2020
@Dunedan Dunedan merged commit 4c0b3ea into Dunedan:master Jul 20, 2020
@Dunedan
Copy link
Owner

Dunedan commented Jul 20, 2020

Sorry, it took me a while to get to this PR, but I finally managed to merge it now.

Thanks a lot for your contribution. 👍

@andyholst andyholst deleted the mbp_13_3_internal_audio_mic_support branch August 12, 2020 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@andyholst @divad42 @AndreasAZiegler @Dunedan @tbzatek