Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/lesson 6 #1

Open
wants to merge 4 commits into
base: Golang-course-Lesson-6
Choose a base branch
from

Conversation

emxqm-11
Copy link

@emxqm-11 emxqm-11 commented Jan 9, 2021

In main.go:

  • fix migrations.Migrate() and removed migrations.MigrateTransaction() which is nonexistent
  • CreateTransaction was missing Amount so the logs for transactions would always show 0 for amount recorded in postgresql
  • i added a lot of debugging errors i got to README so it can be helpful to others.
  • function Transaction()'s updateAccount logic for adding amount to the toAccount was wrong. It used the fromAccount by mistake. Line 56.

@emxqm-11
Copy link
Author

emxqm-11 commented Jan 9, 2021

@radoslawfabisiak Let me know if you want any changes, i know the README was a big change but the rest were bug fixes. Also great work on this tutorial, i loved it ! Hence I wanted to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant