Wrap date fields in Tournament with new Date() #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lets us convert strings to dates w/o impacting current functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrapping the date fields in the
Tournamentclass with anew Date()lets us convert strings to dates (e.g."2019-06-01"becomes the correct date for 6/1/2019) without impacting current functionality (e.g.new Date(new Date("2019-06-01"))is equal in value tonew Date("2019-06-01")). This makes our work easier for the redesign because the current APi workflow likes to output dates as strings instead ofDateobjects, which breaks SciolyFF but is completely fine otherwise.