mixed units of measurement

[homonto]

Describe the bug
the attributes of the sensors have mixed up units: miles and km - I have RAV4 registered in UK (so Europe)
setup of my toyota is in miles
but the sensors from this integration are mixed up - sometimes km sometimes miles

To Reproduce
check the sensor: sensor.rav4_YOUR-PLATE_current_year_statistics

1: the sensor output is: amount of km in current year but the unit of measurements is "mi" - so wrong

2: some attributes are in miles some in km
example:
Average_fuel_consumed: 5.40 - that is in liters/100km
but another one is in miles:
Max_speed: 135 - that is in miles/h
unit_of_measurement: mi - miles
Average_speed: 26.4 - miles

Expected behaviour
the sensors should be consistent and either all in miles or all in km
I checked with MyToyota web page - all there is correct - in miles

[DurgNomis-drol]

Thanks for the feedback.

This a weird bug. I don't manipulate the statistics data, so what you see in the statistic sensor is the raw data from Toyota. But i will take a look at it in the next couple of days and see if I can figure something out, because it shouldn't be mixed like this.

[homonto]

I was 100% sure you take the data from MyT but again: I checked on their www and it shows EVERYTHING in miles.
So it is possible they have a mess there ;-)

[DurgNomis-drol]

I have thought about it and I think i have a solution, but i need to implement it in the python modul, so it is gonna take a couple of days.

And yes, Toyota's API is a bit strange, lets just say that. 😂

[homonto]

I have thought about it and I think i have a solution, but i need to implement it in the python modul, so it is gonna take a couple of days.

And yes, Toyota's API is a bit strange, lets just say that. 😂

I have all the time :-)
Ping when ready to be tested please - thank you

[DurgNomis-drol]

Looking through the code, it seems that both average speed and max speed should also be in km/h, can you double check these for me? So i can be sure want I a can trust from Toyota and want not to trust 😅

[homonto]

average speed and max speed: both are for sure in mph
I am sure I tried if my car can do > 200km/h that is around 134mph ;-)
see what mytoyota says on both occasions:
on top they say: your max was 84mph
on the chart it shows 135mph
same for average: text is different from the chart
total mess

[DurgNomis-drol]

🤣 🤣

[DurgNomis-drol]

Do you want average fuel consumed to be in MPG instead of l/100 miles? Are this the norm in England?

[homonto]

I don't care - I am NOT a Brit although living here
l/100km is ok for me ;-)
mpg is ok for me
as long as all is consistent I think - read: the same units ;-)
of course, if the add-on can have BOTH... am I dreaming? ;-)

[homonto]

see "where" I am today with the mix:

[DurgNomis-drol]

I have now implemented both in the underlying module. I gonna make it default to mpg when the car is using the imperial system (As i believe this is the norm in countries that uses imperial system), with an option to use L/100 miles. How does that sound?

And MPG is of course in UK gallons 😄

[homonto]

it makes sense completely
yes, use UK gallons please - not US ;-)
this country here (UK) is completely upside down: signs on the roads: miles, petrol stations: litres, consumption: mpg, price per litres ... I am not going to tell you more ;-)

[DurgNomis-drol]

Can you please test this branch? #59 And report back over there 😃

[homonto]

can you help me please? how to install the new branch?

[DurgNomis-drol]

https://github.com/DurgNomis-drol/ha_toyota/tree/bugfix

Click this link and press the button called Code, and a dropdown opens up. Choose Download zip.

Extract the zip's content and copy the the folder toyota in the folder custom_components into your custom_components folder. It is gonna ask you to overwrite the other toyota folder installed through HACS. After that you just restart Home-assistant as you would normally when you have installed a custom component. 😃 For more info see this part of the readme.

[homonto]

no change at all - I downloaded, removed old folder, copied new etc
see the results please
maybe I did something wrong?
still some things in miles (ODO), some in km (current year)

[DurgNomis-drol]

Can you try again, I believe I just fixed bug you were encountering 😃

[homonto]

you mean: repeat again the download?

[DurgNomis-drol]

Yes

[homonto]

done
believe me: same same
do you need another screenshot? ;-)
this time with blue

[DurgNomis-drol]

Are you sure you you are downloading this branch and not the master? Because it works on my end when i am testing it 🤔

[homonto]

[DurgNomis-drol]

It is the rights files. I not sure why i does not work

[homonto]

do we have to wait for new pull from MyT?

[DurgNomis-drol]

No, as all the conversion is done in underlying module on the fly. And after you restart when you have installed the new version, it will pull data again (And this time converting it).

Can you please try to download from this again. I just pushed an update that will enable better debugging.

You need to enable the debugging by adding this to your configuration,yaml:

logger:
  default: info
  logs:
     custom_components.toyota: debug
     mytoyota: debug

After this please post the logs only relevant to this integration from the log file 😃

[homonto]

this time green, ok? ;-)

[homonto]

see below (now orange) but I doubt some data is ok: 84 mpg (UK) = 3.36 l/100km - it should be around 5.4-5.6l/100km (as per simple calculation how many litres I fuelled / by km done, also the previous version of your add-on showed 5.4)
https://www.calculateme.com/gas-mileage/liters-per-100-km-to-british-mpg
you can see my all data also on this picture where I note each fuelling:

toyota.log

[DurgNomis-drol]

It defaults to MPG and not L/100 miles. You can change this by going to Settings -> Integrations and then press Configure under the integration.

[homonto]

that is ok, let it be MPG but 5.5l/100km is for sure NOT 84mpg but around 52mpg
let me check it again

[DurgNomis-drol]

Yeah something is wrong with that conversion.

Can you confirm it is the only thing not showing correctly?

[homonto]

no, not only

1. when I use config L/100km it shows correctly the consumption (from 4.9l/100km weekly to 5.4l/100km yearly - I consider this ok as in the summer consumption is lower). but, everything else is in miles - I think (loudly) that the addon should either use everything in miles/gallons or everything in litters/km - for sure not mixed up - what do you think?

2. when I use config MPG then all is in miles - that is OK I think, but MPG is out of the sky (too high)
   

[DurgNomis-drol]

First of all, i not trying to mix them. I am trying to correct this issue.

Secondly, everything is shown correctly for you vehicle except the average consumption attribute. The car denotes want you are gonna see. My car reports in km and therefor this integration show my data in km/L. Your car reports mi and therefor this integration show your data in miles/gallons(UK), you also have the option to show it in miles/liters.

To shorten this, it works correctly when in L/100 miles. For you it is NOT in L/100 km.

WHY the average consumption is wrong when using MPG I don't know right now.

[homonto]

fine, let it be - I will stay with l/100km
just a question: which number do you get from MyToyota for consumption: 5.4l/100km or 84mpg? I am talking RAW data from MyToyota

[DurgNomis-drol]

I don't get anything for my car model, there for your help is need to implement this.

But if you are willing to run a script we can test the mytoyota package as all the conversion is done there.

[homonto]

I am willing to help and contribute ;-)
Provided you will tell me what to do

[DurgNomis-drol]

Create a file called test.py Open the file a paste the below inside and fill in username and password

import json
import asyncio
from mytoyota.client import MyT

username = "jane@doe.com"
password = "MyPassword"

client = MyT(username=username, password=password, locale="en-gb", region="europe")


async def get_information():
    print("Logging in...")
    await client.login()

    print("Retrieving cars...")
    cars = await client.get_vehicles()

    for car in cars:
        vehicle = await client.get_vehicle_status(car)

        statistics = await  client.get_driving_statistics(vehicle.vin)

        print(json.dumps(statistics, indent=3))

        statistics_imp = await  client.get_driving_statistics(vehicle.vin, unit="imperial")

        print(json.dumps(statistics_imp, indent=3))

        statistics_mpg = await  client.get_driving_statistics(vehicle.vin, unit="imperial_mpg")

        print(json.dumps(statistics_mpg, indent=3))


loop = asyncio.get_event_loop()
loop.run_until_complete(get_information())
loop.close()

Run the file like this in a terminal python3 test.py and post the out put here. Remember to censor the output for private information. 😃

[homonto]

that was fast:
➜ tmp python3 test.py
Traceback (most recent call last):
File "/config/tmp/test.py", line 3, in
from mytoyota.client import MyT
ModuleNotFoundError: No module named 'mytoyota'

[DurgNomis-drol]

You need to install the mytoyota module through pip like this pip3 install mytoyota==0.6.0

[homonto]

no private data in the output I think:

python3_test.py.log

[DurgNomis-drol]

I have found the problem i believe. I will need you to test it when i made a fix 😃

[homonto]

I am just around the corner ;-)

[DurgNomis-drol]

Please update the module like this pip3 install mytoyota==0.6.1 and then run the script again and post it 😃

If it errors out when updating, wait a few minutes and try again.

[homonto]

python3_test.py.log

[DurgNomis-drol]

I forgot, you all so have to change imperial_mpg to imperial_liters in test.py

[DurgNomis-drol]

Can i get you to do it again doing the following?

I forgot, you all so have to change imperial_mpg to imperial_liters in test.py

[homonto]

here you are:
python3_test.py.log

[DurgNomis-drol]

It should be working now. I have pushed an update to https://github.com/DurgNomis-drol/ha_toyota/tree/bugfix and it should now be working, please report back

[homonto]

Hmm, now is total mix - I tried to put all findings on 2 pictures: 1st when set l/100km and 2nd when mpg
have a look - the second one is with less errors, the first one with more errors

[homonto]

on 2nd: set to mpg - there is only 1 problem: consumption is in l/100km (all of them) - all distances are in miles - OK
on the 1st one: total mix of problems

[DurgNomis-drol]

I just pushed a fix that should fix it

BUT you need to understand that it is not L/100 KM but L/100 MILES instead.

[homonto]

there is NO such measure in use as L/100 MILES
I have not heard about it at all
commonly used is mpg: miles per UK gallon
or - especially for "imported people" like me from mainland Europe: litres/100km

[DurgNomis-drol]

Use MPG then, there's is no sense in having L/100km if all the other measurements are in miles. This is not discussion. I have worked hard to implement this feature for you and I don't have any use for it personally.

Please test if the latest commit fixed your issue so I can meget this PR og fix the problem.

[homonto]

I am very grateful for your work ;-) thank you.
I just installed it and configured to use MPG - it makes sense to have all in the same units
I believe all is ok now - thank you again

[DurgNomis-drol]

Thanks for testing. I will merge the PR and release a new version very soon to HACS.

Tip: If you still want L/100 km, you can make a template sensor that converts the value. 😃