Bug: Remove stream entry from log_config.yaml #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove `stream` settings from logging settings. In the course of DurgNomis-drol/ha_toyota#218 (reply in thread) I had another look at the `log_config.yaml` and realised that the `stream` setting has no effect. Even if it does not produce a direct error, it is always logged in the stderr regardless of the stream setting.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #315 +/- ##
=======================================
Coverage 70.35% 70.35%
=======================================
Files 32 32
Lines 1511 1511
=======================================
Hits 1063 1063
Misses 448 448
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CM000n
changed the title
GitOldGrumpy
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
streamsettings from logging settings.In the course of DurgNomis-drol/ha_toyota#218 (reply in thread) I had another look at the
log_config.yamland realised that thestreamsetting has no effect.Rather, this currently causes an error when trying to log to a file. After deleting the
streamsetting, logging to a file works again. E.g withpython simple_client_example.py &> test.log