New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor scanners #447
Merged
Merged
Refactor scanners #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgarleanu
force-pushed
the
rfc/scanner-rework
branch
from
May 21, 2022 00:08
828f549
to
1f7d980
Compare
vgarleanu
force-pushed
the
rfc/scanner-rework
branch
from
May 29, 2022 14:14
b98bbd2
to
1336f37
Compare
…l constraint for _tblmedia to allow passing a NULL parameter for the id
vgarleanu
force-pushed
the
rfc/scanner-rework
branch
7 times, most recently
from
June 27, 2022 22:24
81664f6
to
a1893f5
Compare
vgarleanu
force-pushed
the
rfc/scanner-rework
branch
from
July 2, 2022 14:57
a1893f5
to
fc5f4b4
Compare
…minant colors for a image (#464)
vgarleanu
force-pushed
the
rfc/scanner-rework
branch
from
September 18, 2022 14:30
590848f
to
67b7223
Compare
vgarleanu
force-pushed
the
rfc/scanner-rework
branch
from
September 18, 2022 22:13
bccfdd5
to
27067bb
Compare
vgarleanu
force-pushed
the
rfc/scanner-rework
branch
from
September 20, 2022 19:17
27067bb
to
3bdc563
Compare
vgarleanu
force-pushed
the
rfc/scanner-rework
branch
from
September 21, 2022 21:02
31e0fb1
to
41a3b87
Compare
vgarleanu
force-pushed
the
rfc/scanner-rework
branch
from
September 23, 2022 18:14
41a3b87
to
3ea9e62
Compare
vgarleanu
force-pushed
the
rfc/scanner-rework
branch
from
September 23, 2022 18:26
3ea9e62
to
60b7f85
Compare
vgarleanu
force-pushed
the
rfc/scanner-rework
branch
from
September 23, 2022 19:24
0ffc323
to
43339ff
Compare
vgarleanu
force-pushed
the
rfc/scanner-rework
branch
from
September 23, 2022 20:18
2ee3a90
to
6fb0274
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the scanners with the goal of using sqlite transactions more intelligently and efficiently. This new scanner improves the throughput of how many items we can scan and has been re-architected to be easily extendable with metadata providers and filename parsers.
Some stuff has been deleted such as the insertion of posters into the asset fetching queue and the sending of websocket events to clients. This has been done in favour of implementing a CDC based approach to sending events using sqlite commit hooks.
Potential future improvements:
Breaking changes:
min_specialization
. As such arust-toolchain
file has been added to ensure dim is compiled with the latest nightly build.Notes:
The rustc version pinned atm is
nightly-2022-05-31
due to a ICE caused by a MIR bug in latest nightly which causes dim to fail compiling in release mode. Once this is fixed the latest nightly version will be bumped.