This repository has been archived by the owner on Mar 16, 2023. It is now read-only.
Added error message trying to embed empty file #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/etcher.rs
Outdated
Comment on lines
18
to
23
| if byte_data.len() == 0 { | ||
| eprintln!( | ||
| "Empty files cannot be embedded! File names are not retained, so its pointless anyway" | ||
| ); | ||
| std::process::exit(1); | ||
| } |
There was a problem hiding this comment.
Since the return type is a Result, it probably makes more sense to return an Err instead of printing to stderr and exiting the process here, right?
src/etcher.rs
Outdated
| @@ -16,6 +15,12 @@ use crate::timer::Timer; | |||
| pub fn rip_bytes(path: &str) -> anyhow::Result<Vec<u8>> { | |||
| let byte_data = fs::read(path)?; | |||
|
|
|||
| if byte_data.len() == 0 { | |||
| eprintln!( | |||
| "Empty files cannot be embedded! File names are not retained, so its pointless anyway" | |||
There was a problem hiding this comment.
Suggested change
| "Empty files cannot be embedded! File names are not retained, so its pointless anyway" | |
| "Empty files cannot be embedded! File names are not retained, so it's pointless anyway" |
Typo 🙂
|
Please just make it return an Err |
|
It now returns an error, it's definitely more elegant that way. |
|
bc1qa785yw5j5v2mrr4lg5k5g6d935ux6qft3evthn |
Closed
DvorakDwarf
added a commit
that referenced
this pull request
Mar 5, 2023
Added error message trying to embed empty file
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a proper error message when trying to embed an empty file.
See #48