PQKmeans can be pickled! #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kogaki
commented
Dec 29, 2017
|
|
||
| # save current engine and recover from savedata | ||
| engine_savedata = pickle.dumps(engine) | ||
| engine_recovered = pickle.loads(engine_savedata) |
There was a problem hiding this comment.
Just pickle the trained engine instead of creating new class
kogaki
commented
Dec 29, 2017
| init_centers = [] | ||
| self._impl = _pqkmeans.PQKMeans(encoder.codewords, k, iteration, verbose, init_centers) | ||
| self.encoder = encoder | ||
| self._impl = _pqkmeans.PQKMeans(self.encoder.codewords, k, iteration, verbose) |
There was a problem hiding this comment.
Sorry, I removed init_centers to unify the way of loading trained instance. @insikk
matsui528
requested changes
Dec 29, 2017
pqkmeans/clustering/pqkmeans.py
Outdated
| return PQKMeansSavedata( | ||
| encoder=self.encoder, | ||
| k=self._impl.k_, | ||
| iteration=self._impl.k_, |
There was a problem hiding this comment.
This should be self._impl.iteration_
matsui528
approved these changes
Dec 30, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented
__getstate__and__setstate__on PQKmeans following the way #17 .So now we can pickle PQKmeans.