set state to disconnect after failure

[SusannProszak]

when negotiation or start transport failed state was still connecting. signal r connection could not start again.

[joeldart]

Hi Susann,
What situations might we find this? I'm hoping to either get a unit test to add or to get enough steps to where we can create one to match the scenario

[SusannProszak]

Hey,
this sometimes happens when you turn off the internet connection, then try to start the signalR connection. signalR connection fails obviously. when I turn the internet connection on and try to start the signalR connection again the connection state was still in connecting. so there was no way to start the signalR connection.

[donmesserli]

Sorry to send this to everyone. How do I get myself removed from this email list?DonSent from Yahoo Mail for iPhoneOn Oct 15, 2015, 2:54:47 AM, Susann Proszak wrote:Hey,
this sometimes happens when you turn off the internet connection, then try to start the signalR connection. signalR connection fails obviously. when I turn the internet connection on and try to start the signalR connection again the connection state was still in connecting. so there was no way to start the signalR connection.

—Reply to this email directly or view it on GitHub.

[tumatauenga]

Hi Don - you should remove yourself as a watcher of the SignalR-Obj repository.

[abillingsley]

@SusannProszak I finally had a chance to look into this issue. Filed #254 as a result and discovered that other signalr clients do transition to disconnected if negotiate or start transport fails. I was able to create 2 unit tests that prove the state transition error you have observed and have landed those changes. I ended up resolving this slightly differently then the patch you have provided for 2 reasons

1. this PR no longer merges cleanly because of other changes we made
2. your changes simply transition the connectionState. I ended up handling that as part of our pre-existing disconnect code that transitions the state and does some other clean up.

I am closing this PR but know that this issue will be included in the 2.0.3 release