Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified printing preferences, #1122 #1133

Merged
merged 2 commits into from Sep 10, 2023
Merged

Conversation

JackNinway
Copy link
Contributor

No description provided.

Copy link
Contributor

@e9gille e9gille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one minor thing about merging css selector.

Comment on lines 131 to 135
.shc_val {
&::placeholder {
color: transparent;
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge into single selector when only one rule.

Suggested change
.shc_val {
&::placeholder {
color: transparent;
}
}
.shc_val::placeholder {
color: transparent;
}

@e9gille e9gille merged commit fda1d6f into Dyalog:master Sep 10, 2023
1 check passed
@e9gille e9gille deleted the printpref branch September 10, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants