Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDo not abort if a get_tables fails #106
Conversation
This is to alleviate a situation where an external lake formation share is destroyed but an orphaned resource link is still present in the local catalog.
|
Hi @OssiLehtinen this logic of this makes sense. Can you apply the same logic to We probably want to add some documentation that highlights this behaviour, so that the functions are as transparent to the user. Also do you mind adding this to the I am getting ready for the next cran release to resolve issue: #104 . I will hold off until this PR comes into the master branch :) |
|
I made a note of the fix in news.md. The original pull request actually has a fix for dbGetTables (and dbListTables) already, sorry for not pointing those out. |
|
@OssiLehtinen ah don't worry, it was me missing the change to |
|
noctua_1.8.1 has been submitted to the cran. |
An issue connected to the Lake Formation service in AWS appeared:
Lake Formation can be used to share content from one AWS account's glue catalog to another account.
The problem arises, when:
Now, when a user tries to establish a noctua/Athena connection, an error occurs, as the user on account B doesn't have permission to get_tables on account B:s data catalog anymore.
This pull request makes the get_tables error tolerant so that if access is denied, an empty list of tables is put forward.
Probably the multiple tryCatche's are unnecessary now, but I hope this at least outlines the idea how one could address the issue.
Br, Ossi