Performance & Standardization #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: PHPInSimMod.php plugins/LVS.php todo.txt
… standard namespaced classes
…re namespacing efforts to little avail, I don't know what's happening.
|
I may have left out some files in the rush. |
ghost
assigned
|
Fuck, sorry man I messed up originally and had some weird incorrect commits because it was 3am each night for the first few commits, and then I switched out all my progress and moved to something that would be an improvement to what was currently being run without breaking compatibility and it did screw up the metric, I apologize, I'll see if I can't clear it up. |
|
Thank you for the work, it's a great upgrade to the codebase. I can't wait to see the next pull request from you, I'm sure that will be awesome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I modified some of the code for performance and PSR-1 and 2 standards T3charmy added the shell script and made several modifications himself. This version I'm pushing is fully compatible with your current version but should run more smoothly (compatibility and other testing was done by T3charmy) I don't actually play this game I just felt like improving the code base for fun and for a friend.
Also things like the MIT License are actually what is called copyleft, and are intended to remove the sole copyright privileged held by the original author. So I removed the "Copyright" you pasted into the MIT License, though that's quite irrelevant and you can keep it if you want.