Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Non-US backslash to ISO <> #125

Merged

Conversation

HomerSp
Copy link

@HomerSp HomerSp commented Nov 12, 2020

As per #51 the extra ISO key next to the left shift key is named rather confusingly. This fixes that by renaming it to ISO <>.
I don't know why it has the name it does now, or if this key is used for anything else, so if you'd rather keep it with the old name feel free to just close this.

Signed-off-by: Mathias Tillman <master.homer@gmail.com>
@AlexDygma
Copy link
Member

Hey @HomerSp ! Thanks for your continued support 🤩.

But in this case, this change should be made in the nordic layout, not in the punctuation layout, because for the rest of the supported languages the change may or may not be the same, (in this case for the languages that we have it's the same, but that doesn't count future languages), so even tho this works we need to make additional changes to map the particular changes in each language and leave the key representation as <, and when applying shift, we should show >, and AltGr should show | in nordic, but not in spanish for example.

Either Way i'll merge this because it's a good enough temporal solution for this problem and i wont be able to fix the language keys before the end of next week.

@AlexDygma AlexDygma merged commit e09f5fd into Dygmalab:development Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants