Retrieve supported focus commands when opening the port #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lash and App to use this. Signed-off-by: Mathias Tillman <master.homer@gmail.com>
|
Great! This was the correct approach. This way the supported commands are part of the focus library and it's maintenance is done where it should. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I talked about in PR#132, this moves the retrieving of the supported focus commands to the Focus open code and make parts of the code use the new isCommandSupported method. This makes it easier to understand and also removes some duplicated code.
Because of this change I also had to move the stty clocal spawning to the port open method, to make sure it happens before running any commands on the port. This code is supposed to make the OSX connection more stable, so it should work the same way as before. I haven't tested it on OSX though as I only have access to Linux.
Do let me know if this makes sense, or if some parts need to be changed!