-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-arrange keyboard languages and documentation #492
Re-arrange keyboard languages and documentation #492
Conversation
Signed-off-by: Johan Eklund <hello@johaneklund.com>
Signed-off-by: Johan Eklund <hello@johaneklund.com>
Signed-off-by: Johan Eklund <hello@johaneklund.com>
Signed-off-by: Johan Eklund <hello@johaneklund.com>
Signed-off-by: Johan Eklund <hello@johaneklund.com>
Signed-off-by: Johan Eklund <hello@johaneklund.com>
Signed-off-by: Johan Eklund <hello@johaneklund.com>
Signed-off-by: Johan Eklund <hello@johaneklund.com>
Signed-off-by: Johan Eklund <hello@johaneklund.com>
Signed-off-by: Johan Eklund <hello@johaneklund.com>
Signed-off-by: Johan Eklund <hello@johaneklund.com>
Signed-off-by: Johan Eklund <hello@johaneklund.com>
I think the correct language code for the Swiss keyboard would be de_CH, not swg_CH, as it refers to Swiss High German, not the Alemannic dialect. |
Sorry if I was incorrect @zoehneto. I just grabbed the most fitting one from CLDR - Language-Territory Information. |
Signed-off-by: Johan Eklund <hello@johaneklund.com>
I have now updated this PR to change Swiss German to de-CH. Confirms with kbdlayout.info datasheet as well. |
The issue with that list is, that it doesn't really map to how most keyboard layouts are defined (which is typically by nation state). From a keyboard perspective it would make more sense to speak of a Swiss layout (which has German, Italian and French subvariants which only differ in two or three keys) and then there is a German layout and that is quite different. At the same time you have layouts like colemak, bepo or neo, which are optimized for usage with a certain language but obviously don't have a corresponding code in the unicode list. |
…bsites for language codes Signed-off-by: Johan Eklund <hello@johaneklund.com>
Thanks for your feedback, I have updated the documentation to refer to Microsoft and Keyboard Layout Info instead. Yeah, it would be more logical to have Swiss first, not the other way around. It doesn't match for alternative layouts, but it's a start. Right now you need to make up your own for those, e.g. fr-bepo and de-neo. At least we don't need to add Colemak as you can remap your layout however you want. |
Signed-off-by: Johan Eklund <hello@johaneklund.com>
Hey There @jreklund ! I have tried to fix your code but as @zoehneto stated, we have an issue with how to name keyboards like BÈPO, apart from merging all the recent changes that have conflicts, i can solve that part but will leave out the non-standard layouts, do you know how do you want to proceed? |
We got two routes to choose from @AlexDygma. Either we go with "base language" of the keyboard so en-EU (EurKEY), fr-bepo and de-neo or we store those non-standard versions under There are pro/con to both, if we store them with the base language we know what these custom layouts try to solve. But there may be conflicts. Apparently EU exists as an language code, but maybe not as an keyboard. So I may have created an conflict there. According to ISO 3166-1 alpha-2; The code XX is being used by WIPO as an indicator for unknown states, other entities or organizations. So xx-eu, xx-bepo and xx-neo would be safe according to that specification. Path; xx/EU, xx/BEPO, xx/NEO Con: May be hard to see what language they belong to If we want the base language, we could also introduce a second code; en-xx-eu, fr-xx-bepo, de-xx-neo. Path; en/xx/EU, fr/xx/BEPO, de/xx/NEO Pro: We know what base language they belong to There are also the alternative; xx-en-eu, xx-fr-bepo, xx-de-neo, if we want to lock in the base ISO-code for only "real layouts". Path; xx/en/EU, xx/fr/BEPO, xx/de/NEO Pro: We keep real languages separate, creating a clean structure |
Signed-off-by: Johan Eklund <hello@johaneklund.com>
Signed-off-by: Johan Eklund <hello@johaneklund.com>
Signed-off-by: Johan Eklund <hello@johaneklund.com>
The hardest part is to decide on what order it should be shown in the UI. Right now I have them in "Keycaps", "Official" and "Community" order. But for that order to look good we kinda need a seperator in the UI (don't know how to do it), and it's not obvious to the user why that order exists. Positioning BÉPO under French, with the name "French (BÉPO)" seem natural to the user but where should EurKEY go? "English (EurKEY)", as it's base is English? When does a keyboard layout stand on it's own? Should we always use a natural sorting order in the UI, so that Danish are on top, creating A-Z structure there? |
Signed-off-by: Johan Eklund <hello@johaneklund.com>
Signed-off-by: Johan Eklund <hello@johaneklund.com>
Signed-off-by: Johan Eklund <hello@johaneklund.com>
Signed-off-by: Johan Eklund <hello@johaneklund.com>
Hi, after a good night sleep I discovered that more code needed an update. Also fixed an bug introduced after incorrect merge of development branch
|
Great @jreklund! I really like the route that you chose, it's cleaner and easier to maintain, we still need to properly reorganize the UI for this but I will call @thiagohernandez for that 😄, when we have an idea about what to build i will create a local branch on which i will merge your work and add there the new UI 💪 |
you can keep adding code or bugfixes here if you need to! |
Hopefully I don't find any more bugs, I have no known bugs at least. Below are the order it's displayed in the UI.
|
Signed-off-by: Johan Eklund <hello@johaneklund.com>
Signed-off-by: Johan Eklund <hello@johaneklund.com>
|
Signed-off-by: Johan Eklund <hello@johaneklund.com>
|
Signed-off-by: Johan Eklund <hello@johaneklund.com>
Signed-off-by: Johan Eklund <hello@johaneklund.com>
Signed-off-by: Johan Eklund <hello@johaneklund.com>
Signed-off-by: Johan Eklund <hello@johaneklund.com>
Signed-off-by: Johan Eklund <hello@johaneklund.com>
|
Signed-off-by: Johan Eklund <hello@johaneklund.com>
Hi @AlexDygma if I want to contribute a new layout, do you think it makes sense for me to add it using this branch as a starting point. Or is this too early? I don't mind keeping a separate branch for now. I'm still waiting for my Defy :-) |
Hello everyone, I wanted to ask the same question as @jchatard; while waiting for my new Defy to arrive, I was preparing the layout it-IT. |
Signed-off-by: Johan Eklund <hello@johaneklund.com>
Signed-off-by: Johan Eklund <hello@johaneklund.com>
|
Hey there @jreklund !! Yes, for the last time 🤣 I will merge your PR on the next release as you have updated it and now we are working on a full typescript rewrite of the app, so we have to close everything that needs to be closed |
Thanks! I will create some new PR:s to improve language creation after you are finished with the TypeScript migration. 👍 |
This PR re-arranges all language files an "translator" will need to modify. Moving the language parts out from the main file, so you can focus on the translation. Will also help with preventing code conflicts. Adapting a new naming standard for said languages.