Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #24 update usb package #68

Merged
merged 2 commits into from
Nov 9, 2020

Conversation

usagi
Copy link

@usagi usagi commented Apr 17, 2020

@usagi usagi changed the title Fix #347 update usb package Fix #24update usb package Apr 17, 2020
@usagi usagi changed the title Fix #24update usb package Fix #24 update usb package Apr 17, 2020
usagi added 2 commits June 7, 2020 15:09
- Update the usb package to 1.6.3 .
    - Related 1: node-usb/node-usb#348
    - Related 2: https://github.com/tessel/node-usb/releases/tag/v1.6.3

Signed-off-by: Usagi Ito <the@usagi.network>
Signed-off-by: Usagi Ito <the@usagi.network>
@usagi usagi force-pushed the fix-347-update-usb-package branch from 5778442 to cc7479d Compare June 7, 2020 06:11
@elfmimi
Copy link

elfmimi commented Jun 10, 2020

@algernon please merge this.

@NamespaceV
Copy link

0.2.2 fixed usb package issues for me
recommend testing is this still needed

@usagi
Copy link
Author

usagi commented Aug 5, 2020

@NamespaceV Did you test in JAPANESE ENVIRONMENT really? This PR #68 via #24 is fixing for the MSVC and Japanese environment issue, see the node-usb/node-usb#348 via node-usb/node-usb#347 . And it may also happen on a multi-byte character languages environment such as Greek, Cyrillic, Arabic and etc.

@NamespaceV
Copy link

NamespaceV commented Aug 11, 2020

I see commit bumping verison of usb package,
I had issues with usb package that were solved in 0.2.2
So i wrote "I recommend testing newest version"

But it seems version of usb is still 1.6.2
And i had different issues.
So probably bumping to 1.6.3 still valid

[edit] ok you fixed usb package build config,
if the fix is only since usb 1.6.3 then it is definitely valid

@AlexDygma AlexDygma merged commit 2f46437 into Dygmalab:development Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could not build in Windows; Bazecor\node_modules\nan\nan_converters_43_inl.h(22,1): error C2664
4 participants