New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #23 #24
Fixes #23 #24
Conversation
Let me add a test |
@DylanPiercey I am not sure what you would prefer there. I tried adding (some crazy) tests to mock all the various browsers limitations, but the one for IE9 actually doubles the html content and the test fails. Should we just put the while parse-html in istanbul ignore? |
I actually found a way to make the test work. I'll reopen later. Still willing to discuss if we just want to ignore that file for coverage, since it's technically a polyfill |
I was able to add full unit tests to the parse-html polyfill. It's probably one of the weirdest test files I've ever had to write ;) Let me know what you think |
Thanks for the awesome PR. It looks good to me. I don't have the bandwidth at the moment to give a proper review but at the very least I'd like to get this patch out there. |
Cf. bug description, investigation results and context in #23