Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #23 #24

Merged
merged 9 commits into from Nov 8, 2017
Merged

Fixes #23 #24

merged 9 commits into from Nov 8, 2017

Conversation

max-mathieu
Copy link
Contributor

Cf. bug description, investigation results and context in #23

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.2%) to 98.758% when pulling 6f51f76 on max-mathieu:master into d98e542 on DylanPiercey:master.

@max-mathieu
Copy link
Contributor Author

Let me add a test

@max-mathieu max-mathieu reopened this Oct 27, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-11.8%) to 88.199% when pulling 9c6d41c on max-mathieu:master into d98e542 on DylanPiercey:master.

@max-mathieu
Copy link
Contributor Author

max-mathieu commented Oct 27, 2017

@DylanPiercey I am not sure what you would prefer there. I tried adding (some crazy) tests to mock all the various browsers limitations, but the one for IE9 actually doubles the html content and the test fails. Should we just put the while parse-html in istanbul ignore?

@max-mathieu
Copy link
Contributor Author

I actually found a way to make the test work. I'll reopen later. Still willing to discuss if we just want to ignore that file for coverage, since it's technically a polyfill

@max-mathieu max-mathieu reopened this Oct 27, 2017
@max-mathieu
Copy link
Contributor Author

I was able to add full unit tests to the parse-html polyfill. It's probably one of the weirdest test files I've ever had to write ;)

Let me know what you think

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 4664f8e on max-mathieu:master into d98e542 on DylanPiercey:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling f772530 on max-mathieu:master into d98e542 on DylanPiercey:master.

@DylanPiercey DylanPiercey merged commit 3328ba5 into DylanPiercey:master Nov 8, 2017
@DylanPiercey
Copy link
Owner

Thanks for the awesome PR. It looks good to me. I don't have the bandwidth at the moment to give a proper review but at the very least I'd like to get this patch out there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants