Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failed in v4.0.4 #189

Closed
wellyshen opened this issue Apr 22, 2018 · 12 comments
Closed

Build failed in v4.0.4 #189

wellyshen opened this issue Apr 22, 2018 · 12 comments

Comments

@wellyshen
Copy link

Hi I upgraded to v4.0.4. But it cause building failed.

2018-04-22 11 30 42

@DylanVann
Copy link
Owner

Could you try cleaning in xcode and let me know if that fixes it? Thank you

I've added other troubleshooting steps here: https://github.com/DylanVann/react-native-fast-image/blob/master/docs/troubleshooting.md

@edo1493
Copy link

edo1493 commented Apr 22, 2018

I am experiencing the same. :\

ps: we'll go through the troubleshooting and see if everything gets fixed.

@DylanVann
Copy link
Owner

@edo1493 Have you tried those troubleshooting steps?

I've cleaned all the stale data I can think of and installed the new version on a new React Native project and it builds and works for me.

I'd like to be able to test on another machine to be 100% sure but I don't have one available at the moment. Also thinking about setting up some CI for this but all the iOS CI solutions cost money and I'm not sure yet which one would be best for this.

@wellyshen
Copy link
Author

wellyshen commented Apr 23, 2018

@DylanVann,

I did the following thing before building:

  • I unlinked then linked the library.
  • Upgraded this library.
  • I deleted the derivedData from xCode.
  • I cleaned xCode build.

@peterlazar1993
Copy link

Got the same error as well, using pods is not an option for me.

@DylanVann
Copy link
Owner

Alright, I just got this error. Seems to only happen with release builds.

For now I'd suggest keeping the version fixed on the previous release until this is resolved and a new version is published. Sorry

@DylanVann
Copy link
Owner

So it seems like since FastImage is now supposed to use the version of FLAnimatedImage that SDWebImage compiles it needs to use:

#import <SDWebImage/FLAnimatedImageView.h>

Instead of:

#import <FLAnimatedImage/FLAnimatedImageView.h>

It's weird that it works in development mode with the second version but not in production mode.

Also if I do make that change without any other change I think that would break CocoaPods, so there should probably be some sort of conditional there. I'll need to look into it a bit more.

@DylanVann
Copy link
Owner

Apparently when running fastlane #import <SDWebImage/FLAnimatedImageView.h> doesn't work.

@VicFrolov
Copy link

VicFrolov commented Apr 24, 2018

Yep, same issue here. Running in debug mode, but release throws same error. Tried all the steps as well (clearing cache, deleting modules/build folder, watchman del all, npm start reset cache, delete derived data in xcode, cmk shift k)

EDIT: same issue on 4.0.0 for release mode. Works fine in debug mode. Tried using both Xcode, as well as react-native-start in release.

@brianfoody
Copy link

Had to downgrade to 3.0.2

@DylanVann
Copy link
Owner

v4.0.3 should work.

yarn add react-native-fast-image@4.0.3

I'll try to resolve this tonight.

@DylanVann
Copy link
Owner

v4.0.6 is released. This issue should be fixed now.

Ended up doing it like this:

Seems to work in all the scenarios I tested:

  • Debug/Release
  • Using CocoaPods
  • Using fastlane

Let me know if this fixes things, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants