Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

listenUrl defaults to 8080 when using HTTPS #22

Open
trepidity opened this issue May 10, 2013 · 7 comments
Open

listenUrl defaults to 8080 when using HTTPS #22

trepidity opened this issue May 10, 2013 · 7 comments
Labels

Comments

@trepidity
Copy link

Generally, when using HTTPS the port is 443. So if we are using the port in the range of 8080 it should be 8443.

@trepidity
Copy link
Author

Hmmm. So source doesn't show this problem. The problem was in the zip 0.2.3 that I downloaded.

@Dynalon
Copy link
Owner

Dynalon commented May 10, 2013

Might be related to issue #17

Try to specify the port manually in the settings.conf, i.e. set ListenUrl to https://localhost:443 or https://localhost:8443

On Linux, you will need to run rainy as root if you want to listen on port 443.

@trepidity
Copy link
Author

Are you dynamically setting the port in settings.conf at any point?

@Dynalon
Copy link
Owner

Dynalon commented May 10, 2013

I can reproduce that in the 0.2.3 tag branch. If you use ListenUrl: "https://localhost" rainy will not listen on port 443. this is a bug.

@trepidity
Copy link
Author

OK. The original thing I was seeing isn't an issue any more. A commit since 0.2.3 has fixed this case.

Dynalon added a commit that referenced this issue May 10, 2013
@Dynalon
Copy link
Owner

Dynalon commented May 10, 2013

I've created a stable branch based on the 0.2.3 tag that contains a workaround for the issue. I suspect this to be (another) bug in mono's HttpListener implementation. I will leave this bug open until I investigated whether it is a mono bug and I've made sure why this does not affect latest master.

On a sidenote, current master branch is WIP. I've made some changes the last days and the branch is completely unstable and untested. I will see if we can tackle the windows bug an release a 0.2.x based on the stable branch soon.

@trepidity
Copy link
Author

Sounds good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants