Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

context menu bugs and improvement suggestions [2.13.1] #12660

Open
Thomas84 opened this issue Feb 27, 2022 · 5 comments
Open

context menu bugs and improvement suggestions [2.13.1] #12660

Thomas84 opened this issue Feb 27, 2022 · 5 comments

Comments

@Thomas84
Copy link
Contributor

Thomas84 commented Feb 27, 2022

Dynamo version

2.13.1

Operating system

win10

What did you do?

right click on node -> left click on context menu

right click on canvas -> left click on context menu

What did you expect to see?

(Fill in here)

What did you see instead?

image

image

Context menu is not updated after deactivating the background preview of a node. "Hide geometry" is still shown, even the node is hidden already:
https://user-images.githubusercontent.com/5624034/155883469-cdae5516-1e8f-4131-b7c1-224cb8decfb1.mp4

In addition: if multiple nodes are selected and using the context menu (by right click on a node) to deactivate the background preview, it should deactivate the background preview of all selected nodes, even if you use the context menu of that singe node. This behavior is already available in the context menu of the canvas, but not in the context menu of a node.
If the behavior is different depending on where you right click, it is difficult to understand for the users.

@Amoursol
Copy link
Contributor

Hi @Thomas84 - Many thanks for submitting these suggestions! A few comments and thoughts:

  1. I cannot reproduce the exit that you see when left clicking on a node context menu item with a sub-menu. Does this still exist for you in the latest Daily Build? I can reproduce this in the canvas right-click context menu, so will file a bug on that!
  2. I can reproduce the Pan missing a check-mark, so will file this one too!
  3. @Thomas84 can you please explain a bit more about the "Node to Code" Why not here? comment? I'm unsure what you mean.
  4. Ditto for "Copy"
  5. Can you please confirm what you are seeing in a GIF for the "Context menu is not updated..." comment? Currently, we have a "Preview" toggle that is on, or off based on the checkmark next to it in the nodal context menu, and the canvas right-click menu has "Show/Hide Geometry Preview"
  6. While I hear you on this, we will not be doing this as it muddies the waters from a UX perspective - each nodal context menu is singular to that node, and the canvas right-click menu is global to all selections 😊

@Jingyi-Wen any thoughts on making the nodal context menu and canvas one more similar? My 2 cents are that they are different things, one dealing with a singular entity, the other with multiple based on selection, so I can see both sides.

@Jingyi-Wen
Copy link

Thank you @Thomas84

  • The context menus are definitely as @Amoursol mentioned. But should definitely match the names and have a hierarchy for the same item (action taken during multiple nodes selection should override the singular action).
  • I agree the Node to Code should be in the node context menu instead of the canvas

@Amoursol
Copy link
Contributor

Amoursol commented Mar 24, 2022

@Jingyi-Wen Can we mock-up a consistent version of both menus? I can create a task. We can also add "Node to Code" into the Nodal context menu, but definitely want to keep it in the canvas right-click menu as it's intended mostly for multiple nodes.

@Thomas84
Copy link
Contributor Author

Thomas84 commented Apr 6, 2022

Hi @Thomas84 - Many thanks for submitting these suggestions! A few comments and thoughts:

  1. I cannot reproduce the exit that you see when left clicking on a node context menu item with a sub-menu. Does this still exist for you in the latest Daily Build? I can reproduce this in the canvas right-click context menu, so will file a bug on that!
  2. I can reproduce the Pan missing a check-mark, so will file this one too!
  3. @Thomas84 can you please explain a bit more about the "Node to Code" Why not here? comment? I'm unsure what you mean.
  4. Ditto for "Copy"
  5. Can you please confirm what you are seeing in a GIF for the "Context menu is not updated..." comment? Currently, we have a "Preview" toggle that is on, or off based on the checkmark next to it in the nodal context menu, and the canvas right-click menu has "Show/Hide Geometry Preview"
  6. While I hear you on this, we will not be doing this as it muddies the waters from a UX perspective - each nodal context menu is singular to that node, and the canvas right-click menu is global to all selections 😊

@Jingyi-Wen any thoughts on making the nodal context menu and canvas one more similar? My 2 cents are that they are different things, one dealing with a singular entity, the other with multiple based on selection, so I can see both sides.

_1 is fixed in Revit 2023 🎉
_3 "node to code" and the "copy" option should be available if you right click on a node (they are available if u right click on an empty area). And in my opinion all actions of the context menu should be on all nodes which are selected at the moment. If u want to do something with a single node, the user should only select a single node.
_5 it's shown in the video. I deactivated the geometry preview by right clicking on the node. The second right click is on the empty canvas. The context menu still give me the option the "deactivate geometry preview". But the geometry preview is already deactivated. The canvas context menu gets refreshed only, if you unselect the node and reselect it.
_6 The behavior is not consistent. For example if you have selected some nodes, and u make a right click on one of the selected nodes and select "create group", all selected nodes are grouped. But if u have selected some nodes and right click on a node to deactivate the geometry preview, only the single to is affected. As said above, in my opinion, all actions of the context menu should be on all nodes which are selected during that moment. If u want to do something with a single node, the user should only selected a single node. Please think about it again with the team and compare it with actions on Revit Elements or behavior in other software. I think in most software actions are done on selected stuff, as long as the action makes sense on multiple elements.

@Thomas84
Copy link
Contributor Author

Thomas84 commented Apr 25, 2022

canvas right-click context menu bug still available in 2.14 sandbox.

25-04-_2022_20-19-40.mp4

And why does the context menu always open to the left? The right side would be a shorter way for the user
image

And I'm just wondering: why is there no "delete" in the canvas context menu for deleting multiple selected nodes? 🙄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants