Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not discard unsaved changes when you click X in save dialog #12756

Merged
merged 1 commit into from
Mar 30, 2022

Conversation

zeusongit
Copy link
Contributor

@zeusongit zeusongit commented Mar 30, 2022

Purpose

Do not discard unsaved changes when you click X in save dialog
Also, removed the extra add group to group analytics point

DynamoSandbox_4oGEpCELG2

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

  • Do not discard unsaved changes when you click X in save dialog

Reviewers

@QilongTang

@QilongTang
Copy link
Contributor

Would you also attach a gif of behavior change (although back to expected)?

@zeusongit zeusongit merged commit 476dd71 into DynamoDS:master Mar 30, 2022
@zeusongit zeusongit deleted the dynclse branch March 30, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants