Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Icons for a Zero Touch Assembly or Node Model assembly, Not work with NET6 SDK Style #13199

Closed
chuongmep opened this issue Aug 10, 2022 · 4 comments

Comments

@chuongmep
Copy link
Contributor

Hi, Im try work with NET6 SDK Style target Net Framework 4.8, and I have a problem with generate file SampleLibraryZeroTouch.customization.dll to map icon but it not working.
Origin Guide : https://github.com/DynamoDS/Dynamo/wiki/Add-Icons-for-a-Zero-Touch-Assembly-or-NodeModel-assembly

<Target Name="AfterBuild">
  <!-- Get System.Drawing.dll -->
  <GetReferenceAssemblyPaths TargetFrameworkMoniker=".NETFramework, Version=v4.7">
    <Output TaskParameter="FullFrameworkReferenceAssemblyPaths" PropertyName="FrameworkAssembliesPath" />
  </GetReferenceAssemblyPaths>
  <!-- Get assembly -->
  <GetAssemblyIdentity AssemblyFiles="$(OutDir)$(TargetName).dll">
    <Output TaskParameter="Assemblies" ItemName="AssemblyInfo" />
  </GetAssemblyIdentity>
  <!-- Generate customization dll -->
  <GenerateResource  SdkToolsPath="$(TargetFrameworkSDKToolsDirectory)" UseSourcePath="true" Sources="$(ProjectDir)\Resources\SampleLibraryZeroTouchImages.resx" OutputResources="$(ProjectDir)\Resources\SampleLibraryZeroTouchImages.resources" References="$(FrameworkAssembliesPath)System.Drawing.dll" />
  <AL SdkToolsPath="$(TargetFrameworkSDKToolsDirectory)"  TargetType="library" EmbedResources="$(ProjectDir)\Resources\SampleLibraryZeroTouchImages.resources" OutputAssembly="$(OutDir)SampleLibraryZeroTouch.customization.dll" Version="%(AssemblyInfo.Version)" />
</Target>

This is my project setting 2 year ago in Net Framework 4.5, and it's working : https://github.com/chuongmep/ZeroTouchIconTemplate/tree/master
OUTPUT :
image

My Demo Project not working with NET6 SDK Style target Net Framework 4.8 branch net6_48 : https://github.com/chuongmep/ZeroTouchIconTemplate/tree/net6_48
OIutput:
image

Any have solution appreciate !

@github-actions
Copy link

Hello chuongmep, thank you for submitting this issue! We are super excited that you want to help us make Dynamo all that it can be. However, given that there has been no additional information added, this issue will be closed for now. Please reopen and provide additional information if you wish the Dynamo team to investigate further.

Additional information:

  • Filling in of the provided Template (What did you do, What did you expect to see, What did you see instead, What packages or external references (if any) were used)
  • Attaching the Stack Trace (Error message that shows up when Dynamo crashes - You can copy and paste this into the Github Issue)
  • Upload a .DYN file that showcases the issue in action and any additional needed files, such as Revit (Note: If you cannot share a project, you can recreate this in a quick mock-up file)
  • Upload a Screenshot of the error messages you see (Hover over the offending node and showcase said errors message in the screenshot)
  • Reproducible steps on how to create the error in question.

@QilongTang
Copy link
Contributor

@jasonstratton I do not suppose you guys looked at this one yet?

@QilongTang QilongTang reopened this Aug 10, 2022
@pinzart90
Copy link
Contributor

@chuongmep I created a PR to fix this problem
chuongmep/ZeroTouchIconTemplate#1
Please test it locally

@chuongmep
Copy link
Contributor Author

chuongmep commented Aug 12, 2022

@chuongmep I created a PR to fix this problem chuongmep/ZeroTouchIconTemplate#1 Please test it locally

Sorry I'm reply late, tested and it working perfect. Thank you .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants